Notify changes for favorites files

[PVince81]

Add new activity option "File or folder that is a favorite has changed".

Not sure how this would work.
Does it mean non-favorited files should not have activity entries any more ?

@karlitschek @nickvergessen

[karlitschek]

this would be an additional option. so for example a user could get updates of all files in the activity stream but emails only for the favorites.

[nickvergessen]

Let's figure out the details tomorrow then

[nickvergessen]

Okay, after having some thoughts and a discussion at lunch, we came to the conclusion,
that this is not easily possible.

The problem is, we need to get the shared file, then for each user check whether the file or a parent folder is marked as favorite. Since the paths may be different for each user, this means at least a few queries per user (check tag for file, [get parent folder, check tag for parent,]* ...), so e.g. in an installation with thousands of users, we run thousands of additional queries, just to find out, that we don't need to do anything.

So unless someone has a good idea how to better do this, I would abstain from this atm.

[RobinMcCorkell]

If this is still desired, please open a new issue over at owncloud/activity.

[nickvergessen]

No, actually activities are not part of the activity app. The activity app is just an empty framework without any context. Also there is already a PR open:
#15196

[nickvergessen]

Implemented in 8.1