-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework/improve the file scanner / file cache #11753
Comments
Something I noticed is that the scanner still operates and tries to detect changes even for the home storage. It might make sense to disable the scanner completely for the home storage as the use case is that this one is ONLY used through ownCloud. It would be good to do some performance tests and see whether it helps in any way. Disabling the scanner would also help with concurrency issues (see #11795) where the file scanner detects FS changes in the home storage, changes done by another process which didn't have a chance yet to update the cache to match the new data. Or... if the scanner is not disabled, allow it to run only once per user. Which means multiple scanner processes are not allowed to run at the same time for the same user. |
|
Scanner concurrency issues have been solved and propagation has been reworked too. I think we can close this. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If we had to write it again from scratch, I have the feeling that the file scanner / cache would probably be implemented differently. The current one is mostly evolved from earlier versions.
Things that we need the file cache for:
What kind of different approach could be used to achieve these ?
Would an event system of some sorts help ?
Should the scanner be running in its own process instead of concurrently ?
@icewind1991 did you ever dream of a better file scanner ? How would that one look like ?
The text was updated successfully, but these errors were encountered: