Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release contacts 1.5.6 #710

Open
phil-davis opened this issue Apr 14, 2021 · 6 comments
Open

Release contacts 1.5.6 #710

phil-davis opened this issue Apr 14, 2021 · 6 comments
Labels

Comments

@phil-davis
Copy link
Contributor

Because of issue #708 fixed by PR #709

Someone needs to check if the problem is just related to recent changes in core master, and thus a release is only needed along with core 10.7.1. Or if the release needs to/can work with older ownCloud core 10.7, 10.6...

@jnweiger jnweiger changed the title Release 1.5.6 Release contacts 1.5.6 Apr 21, 2021
@jnweiger
Copy link

Is a new release also needed to work with 10.8.0 ?

@phil-davis
Copy link
Contributor Author

I am not sure. Someone needs to check if the current marketplace-released/bundled contacts app has UI working nicely with a core 10.8.0 system. (CI is not going to tell us that, because various JS libraries have been updated in PR #709 in master of this repo)

If we decide to do a new release, then we need to either:

  1. set the core min version to 10.8.0, or;
  2. manually verify that the latest contacts app code works correctly on older core 10.* versions (info.xml currently has owncloud min-version="10.2" so we would have to decide how many version back to test, and set min-version appropriately)

@jnweiger
Copy link

jnweiger commented Jul 20, 2021

Issues seen while testing

"UI working nicely" is not how I would phrase it. Let's say "almost acceptably" :-)

Same with server 10.7.0 -- apart from that, contacts works "fine" for me on 10.8.0 RC1 !

Security issues seen

@jnweiger jnweiger added the QA:p4 label Jul 22, 2021
@jnweiger
Copy link

Release not done by BTR team. removed from Board.

@phil-davis
Copy link
Contributor Author

@DeepDiver1975 did this release https://github.com/owncloud/contacts/releases/tag/v1.5.4

Are you the one who does releases of contacts? Or?

@jnweiger
Copy link

jnweiger commented Jul 31, 2023

We'll do a release this week, it seems...

Dependabots has onen critical issue:

The build reports several security issues, and deprecated dependencies:

found 37 vulnerabilities (2 low, 15 moderate, 11 high, 9 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
> npm install && npm update && node_modules/bower/bin/bower install && node_modules/bower/bin/bower update

npm WARN deprecated [email protected]: https://about.codecov.io/blog/codecov-uploader-deprecation-plan/
npm WARN deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated [email protected]: This module is no longer maintained, try this instead:
npm WARN deprecated   npm i nyc
npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.
npm WARN deprecated [email protected]: This package is unmaintained. Use @sinonjs/formatio instead
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: 4.x is no longer supported. Please upgrade to 6.x or higher.
npm WARN deprecated [email protected]: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated [email protected]: 2.x is no longer supported. Please upgrade to 4.x or higher.
npm WARN deprecated [email protected]: 1.x is no longer supported. Please upgrade to 3.x or higher.
npm WARN deprecated [email protected]: The v1 package contains DANGEROUS / INSECURE binaries. Upgrade to safe fsevents v2
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: CircularJSON is in maintenance only, flatted is its successor.

@jnweiger jnweiger added this to Releases Aug 8, 2024
@jnweiger jnweiger moved this to In dev in Releases Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In dev
Development

No branches or pull requests

2 participants