Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the Wizard #9249

Closed
1 task done
TheOneRing opened this issue Nov 30, 2021 · 9 comments
Closed
1 task done

Rewrite the Wizard #9249

TheOneRing opened this issue Nov 30, 2021 · 9 comments
Assignees
Labels
Milestone

Comments

@TheOneRing
Copy link
Contributor

TheOneRing commented Nov 30, 2021

Missing

  • App passwords

Its time to rewrite redesign the wizard.

In #5030 we got a proposal design for the wizard.
Lacking in the proposal are oauth and webfinger.

Webfing:

Either an additional page after the server is selected or an input field on the initial server page.

Fixed url

If the url is branded we currently directly continue to the login, using oauth or basic auth.
If no account is present yet we will open the wizard on start, which with oauth will directly open the browser with out any guidance of the user.

  • Provide a "Start" button and a description on what will happen after the wizard process stats.

Advances setup

The selection of the default folder, the syncing mechanism, selective sync, or manual sync are all advanced features.

  • I'd suggest to a "Show advanced settings" checkbox on all pages, only if the the option is selected the advanced page is displayed, else we end after authentication. (What to do when the default folder already exists)
    • There will only be one advanced page with settings, the option won't enable additional settings on the other pages.
  • Customers already requested to disable the advanced step, in this case we would just hide that checkbox

TODO

  • How to display errors

Related:

@TheOneRing
Copy link
Contributor Author

@tbsbdr While looking deeper I had the idea of using setup page in between the pages, this page then would display a spinner/error.

@tbsbdr
Copy link

tbsbdr commented Dec 2, 2021

Not sure if I understood you - what problem would an in-between page solve?

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 2, 2022
@TheOneRing TheOneRing removed the Stale label Jan 4, 2022
@TheOneRing TheOneRing modified the milestones: 2.10, webfinger Jan 4, 2022
@TheOneRing TheOneRing modified the milestones: webfinger, 2.11 Feb 17, 2022
@TheOneRing
Copy link
Contributor Author

TheOneRing commented Mar 24, 2022

Current todos:

  • VFS
  • Changing target dir
  • Integrate webfinger Webfinger #9366
  • Selective sync?
  • Invalid SSL certficate dialog

@fmoc
Copy link
Contributor

fmoc commented May 31, 2022

What needs to be done regarding app passwords? They work just fine already, it seems.

@TheOneRing
Copy link
Contributor Author

What needs to be done regarding app passwords? They work just fine already, it seems.

We used to display a url to the app password settings in oc10 and mention the existance of app passwords.

@fmoc
Copy link
Contributor

fmoc commented Jul 29, 2022

Looks like we finished all the TODOs. Closing therefore.

@HanaGemela
Copy link
Contributor

Test:
Regression test that no features are missing in comparison with 2.11 client

@HanaGemela
Copy link
Contributor

Some features missing - will be fixed in #10266

@HanaGemela HanaGemela moved this from Todo to Done in Desktop Testing Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants