Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: switch to QDnsLookup instead of letting Qt do the lookup (which caches it for 30 sec or so..) #6676

Open
michaelstingl opened this issue Jul 30, 2018 · 3 comments

Comments

@michaelstingl
Copy link
Contributor

see comment in closed issue:
#203 (comment)

@guruz
Copy link
Contributor

guruz commented Jul 30, 2018

Right now we don't do DNS lookups manually, we rely on QNetworkAccessManager to do it internally for us)
This would involve adding a DNS-lookup step to our ConnectionValidator.
I'm thinking maybe we can't even do this because QNetworkAccessManager only takes URLs but we'd want URL+IP4/6.

One idea would be to patch our Qt to not do caching in QHostInfo (which is used internally by Qt).

@ogoffart
Copy link
Contributor

I don't understand why we would one to do that. Caching the DNS is a required feature, we do lots of query to the network, and we don't want to add a dns query delay between each of them.

@guruz
Copy link
Contributor

guruz commented Jul 31, 2018

I don't understand why we would one to do that.

See linked issues in original post.

Caching the DNS is a required feature, we do lots of query to the network, and we don't want to add a dns query delay between each of them.

There's also the OS-level cache which is I think the one you're talking about. Usually it's invalidated when the OS has a network connection change. QHostInfo does not do this invalidation (although it could with QNetworkConfiguration but that was never implemented)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants