Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] [2.2.4 build 6408] does not re-include unavailable local sync folders when they are available again. #5317

Closed
TDannhauer opened this issue Nov 16, 2016 · 15 comments
Assignees
Labels
ReadyToTest QA, please validate the fix/enhancement type:bug
Milestone

Comments

@TDannhauer
Copy link

Expected behaviour

After adding a folder sync to a removable drive (e.g. stick or Veracrypt container), the client complains after system boot: It marks the unaccessible folder with a read cross and says "Unable to find local sync folder."

After making the missing folder accessible, ( e.g. mounting the encrypted device), the missing folder should be re-evaluated (time or event based) by the OC client and included into sync activities as soon as it is available again.

This would make it convenient to setup local sync folders on encrypted devices.

Actual behaviour

However, after making the missing folder accessible, ( e.g. mounting the encrypted device) does not re-enable syncronisation for that folder. Only manually pausing and resuming sync triggers the OC client to re-evaluate the folder, to find it and to re-enable its synchronisation.

Steps to reproduce

Setup a folder syncronisation on a accessible removable drive (like a Truecrypt/veracrypt container)
2.
Make drive unaccessible at bootup.
3.
Setup Owncloud Client to auto start at user login
4.
Reboot system
5.
Look at Owncloud client: It marks the unaccessible folder with a read cross and says "Unable to find local sync folder."
6.
Make folder accessible again, e.g. by mounting it in Veracrypt
7.
Look at Owncloud client: It still marks the unaccessible folder with a read cross and says "Unable to find local sync folder.".
8.
Pause sync for that folder manually.
9.
Resume sync for that folder manually.
10.
Look at Owncloud client: It now finds the accessible folder and re-enables sync for that folder.

Server configuration

Operating system:
Debian Jessie

Web server:
Apache 2.4.10

Database:
Postgres 9.3

PHP version:
PHP-FPM 5.6.27

ownCloud version:
9.1.2

Storage backend (external storage):
none

Client configuration

Client version:
2.2.4 build 6408

Operating system:
Win10 64 bit

OS language:
DE

Installation path of client:
C:\Program Files (x86)\ownCloud

@guruz guruz changed the title Desktop client 2.2.4 build 6408 does not re-include unavailable local sync folders when they are available again. [Windows] [2.2.4 build 6408] does not re-include unavailable local sync folders when they are available again. Nov 16, 2016
@guruz guruz added the type:bug label Nov 16, 2016
@guruz guruz added this to the 2.3.0 milestone Nov 16, 2016
@SamuAlfageme
Copy link
Contributor

It's not reproducing in Windows 7/10. The folder is automatically found, no need to Pause/Resume the sync. It just takes a bit (<20s) to be found and synced again.

@TDannhauer
Copy link
Author

Have you used veracrypt with a encrypted container to reproduce? Are you usi g Win10 1607 64 bit?

I waited 120 min and it highly reproducable. Should i make a screen video?

Torben

Von unterwegs gesendet
Sent from mobile

Am 16.11.2016 um 14:39 schrieb Samuel [email protected]:

It's not reproducing in Windows 7/10. The folder is automatically found, no need to Pause/Resume the sync. It just takes a bit (<20s) to be found and synced again.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@SamuAlfageme
Copy link
Contributor

@TDannhauer yup, followed every step. The thing is, I was trying to reproduce it unsuccessfully right after windows restarting and the client launch: look at this video).

But you are right, some time after the OS startup, the client is not checking if the folder is available anymore. I'm reopening to keep that availability check open. Appending this logfile here describing what's happening after adding that folder some time after the startup.

@TDannhauer
Copy link
Author

Great, thanks for your investigation!

@ckamm
Copy link
Contributor

ckamm commented Dec 6, 2016

Looking at it briefly, I see these issues:

  • When the sync fails with the "Unable to find local sync folder" message, the sync isn't retried with a short interval. It probably is retried when the long-sync period expires, but that takes several hours.
  • Even when a sync is triggered (though pause/unpause or force-sync/F6), the folder watchers aren't set up. And thus the folder isn't watched for local changes from then on.
  • It should also work if the path goes away for an hour and then comes back (USB drive removed, then reconnected). This needs some FolderWatcher reinitialization, I guess.

@ckamm
Copy link
Contributor

ckamm commented Dec 6, 2016

Work in progress branch for these issues: https://github.com/ckamm/owncloud-client/tree/late_local_folder_5317

ckamm added a commit to ckamm/owncloud-client that referenced this issue Dec 13, 2016
Like "folder doesn't exist" - such that we will detect when the folder
becomes available and start syncing.

See owncloud#5317
ckamm added a commit to ckamm/owncloud-client that referenced this issue Dec 13, 2016
Also retry creating it before each sync.

See owncloud#5317
@ckamm
Copy link
Contributor

ckamm commented Dec 13, 2016

Pull request: #5381

I think there are several issues with "temporarily unavailable" sync folders (folder watchers, potentially sync journal db access) that are not yet solved. This is just the first step towards making that work.

guruz pushed a commit that referenced this issue Jan 2, 2017
Like "folder doesn't exist" - such that we will detect when the folder
becomes available and start syncing.

See #5317
guruz pushed a commit that referenced this issue Jan 2, 2017
Also retry creating it before each sync.

See #5317
@guruz guruz added the ReadyToTest QA, please validate the fix/enhancement label Jan 2, 2017
@guruz
Copy link
Contributor

guruz commented Jan 5, 2017

@TDannhauer
Copy link
Author

TDannhauer commented Jan 5, 2017 via email

@guruz
Copy link
Contributor

guruz commented Jan 5, 2017

Sure :)

@TDannhauer
Copy link
Author

TDannhauer commented Jan 5, 2017 via email

@guruz
Copy link
Contributor

guruz commented Jan 5, 2017

@TDannhauer You can install over the old version, the uninstaller won't remove settings

@TDannhauer
Copy link
Author

TDannhauer commented Jan 6, 2017 via email

@SamuAlfageme
Copy link
Contributor

👍

@Challado
Copy link

Hello Friends.
These bug has appeared again. On earlier versions of owncloud all works fine, but now I need to remount unit in veracrypt and close/open owncloud to start sync volume again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToTest QA, please validate the fix/enhancement type:bug
Projects
None yet
Development

No branches or pull requests

5 participants