Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When server files with invalid paths are ignored, the error is only visible in the activity tab #3902

Closed
hmcs opened this issue Sep 29, 2015 · 7 comments
Assignees
Milestone

Comments

@hmcs
Copy link

hmcs commented Sep 29, 2015

Hi,

Via Web it is possible to create a directory-name ending with a space like "my folder " (tested on owncloud Server 8.1.3).
The Windows-client (Version 2.0.1) has problems syncing this folder because spaces at begining or ending are not allowed in windows. Nasty, it generates no error in log.

I assume, this apply also to files but not tested.

regards,

henry

@Dianafg76 Dianafg76 modified the milestones: 2.1-next, 2.0.2-current Sep 29, 2015
@Dianafg76
Copy link

Hello

  1. Go to the Server Web with user2
  2. Create new folder (e.g. call "File with space ")
  3. Go to the Desktop Client with user2
  4. Wait for Sync
  5. You can see the folder "File with space "
    screen shot 2015-09-29 at 12 45 06
  6. If you open the folder c:/....../user2, you can't see the folder "File with space "
    screen shot 2015-09-29 at 12 47 44
  7. On the Desktop Client if you click on Settings...
  8. Click ib Activity option, you can see:
    screen shot 2015-09-29 at 12 49 40

@Dianafg76
Copy link

I tested on WIN 10
Desktop v ownCloud-2.0.2.5499-nightly20150928-setup.exe

@Dianafg76
Copy link

And If you create a new folder on the desktop client is created without problem

@hmcs
Copy link
Author

hmcs commented Sep 29, 2015

shouldn't begining/ending "spaces" be not allowed in web-interface?

@Mistress-Anna
Copy link

Leading/trailing whitespace is generally a user typo anyway, which can be easily trimmed.

File and folder names shouldn't end with spaces or periods on windows:

Do not end a file or directory name with a space or a period. Although the underlying file system may support such names, the Windows shell and user interface does not. However, it is acceptable to specify a period as the first character of a name. For example, ".temp".

https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx#naming_conventions

This also means "foobar..." is not an acceptable folder name on windows.

@ckamm
Copy link
Contributor

ckamm commented Sep 30, 2015

So

  • We might want to evaluate whether the client should produce a louder error when it's ignoring server files that are not valid on the current system. I think this is low-priority and not for 2.0.2.
  • The web interface should not allow creating files or folders with leading/trailing spaces.

I'll create a new ticket against the server for the second part and adjust this ticket for first.

@ckamm ckamm changed the title Error sync folder ending with "space" When server files with invalid paths are ignored, the error is only visible in the activity tab Sep 30, 2015
@ckamm ckamm added sev4-low and removed sev2-high labels Sep 30, 2015
@ckamm ckamm modified the milestones: 2.1-next, 2.0.2-current Sep 30, 2015
@ogoffart
Copy link
Contributor

ogoffart commented Nov 4, 2015

The hiding of them in the selective sync tree was fixed in #3876

The fact that ignored files/directories should be made more visible is another problem and there are other issues about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants