Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select the new Folder for Sync #3190

Closed
Dianafg76 opened this issue May 5, 2015 · 16 comments
Closed

Can't select the new Folder for Sync #3190

Dianafg76 opened this issue May 5, 2015 · 16 comments

Comments

@Dianafg76
Copy link

Steps to reproduce

  1. Open your ownCloud desktop client
  2. Select to sync all your data in a folder called 'ownCloud'
  3. Select to "Add Folder..."
  4. Click on "Choose.."
  5. Select the local folder on your computer to Sync, for example "Sync folder3"
  6. Press "Open", and next press "Continue"
  7. Click on "Create folder", create it on the root, called it "test"
  8. Select test

Expected behaviour

You should be able to add the Folder

Actual behaviour

A warning appears, and you can't continue:
screen shot 2015-05-05 at 09 23 59

Version Desktop

Version 1.8.1.2326-nightly20150504 MAC

Web server:
{"installed":true,"maintenance":false,"version":"8.0.3.4","versionstring":"8.0.3","edition":"Enterprise"}
Checked with a server with permanent redirection
LDAP and Encryption enable

@guruz
Copy link
Contributor

guruz commented May 5, 2015

I think this is a artificial limitation that had been discussed before with @jancborchardt and @MTRichards
Maybe it should be lifted

@jancborchardt
Copy link
Member

This is not artificial. The problem is:

  1. You have your whole server root synced with your local »ownCloud« folder
  2. You add a local folder outside of the »ownCloud« folder to sync with your server
  3. First question: Where should it go? I assume the root folder.
  4. Second question: Will it then be synced down into the local »ownCloud« folder again, hence duplicating it?

Even if it would technically be doable (put the folder in the root, but don’t sync it down again), it would be confusing as on the server the one folder is on the same root level but on the computer it is somewhere completely different.
(Now when all your folders are picked via the »Add folder« dialog that is different, because everything is all over the place.)

@danimo
Copy link
Contributor

danimo commented May 5, 2015

We can solve this by allowing the same user/server on multi accounts, but allow different folder pairs. If we really want to, that is.

@danimo danimo closed this as completed May 5, 2015
@jancborchardt
Copy link
Member

@danimo that sounds like a crazy and absolutely undiscoverable workaround though.

@jancborchardt
Copy link
Member

Also – I would say no, we do not want to support this. For reasons stated above.

@MTRichards please chime in.

@dragotin
Copy link
Contributor

dragotin commented May 5, 2015

.o0( popcorn )

@dragotin
Copy link
Contributor

dragotin commented May 5, 2015

I think the "Add folder" button should be disabled if the user syncs the entire ownCloud to a local dir. We want to reduce complexity.

@MTRichards
Copy link

This is interesting because I ran into the same thing yesterday. We mixed two capabilities, the sync all with selective sync, and the sync whatever folders you want. I understand the overall point, if you sync the root folder on one machine, you can't sync other folders on that machine - it just doesn't work. And this is by design.

That said, I like @dragotin 's solutions on how to mix - if you sync the entire root folder on that client, you can't pick a new folder to sync (except on a second ownCloud account of course).

@guruz
Copy link
Contributor

guruz commented May 5, 2015

.o0( popcorn )

img_20150505_145845

@guruz
Copy link
Contributor

guruz commented May 5, 2015

I understand the overall point, if you sync the root folder on one machine, you can't sync other folders on that machine - it just doesn't work. And this is by design.

See also #1122 ... Not sure if good design.

@jancborchardt
Copy link
Member

I think the "Add folder" button should be disabled if the user syncs the entire ownCloud to a local dir. We want to reduce complexity.

This sounds like a good solution first, but makes it not very clear why it is available but disabled. Remember this is the default state. So instead showing that notice in the »Add folder« dialog like it is now is definitely better than just disabling it.

@MTRichards
Copy link

Sure, I would do both - disable the button and explain why - the current warning is for the purpose of explaining. Problem is it is already well into the "add a folder" dialog when you get the warning, so you want to do something and just can't, and that is frustrating.

Perhaps just a "You are already syncing all server folders with this client." if you mouse over the disabled button, something like that?

@MTRichards
Copy link

Also the same as: #2147

@jancborchardt
Copy link
Member

@MTRichards ok, that’s a good solution. @dragotin if a title / hover like that works, then let’s do it.

@MTRichards
Copy link

See also #1122 ... Not sure if good design.

Suggestions welcome 😝

We tried this with syncing all files, then a lower level folder called clientsync, then we tried it with syncing the whole tree again by default. Then we added selective sync to each syncing pair. Bottom line, there is no good default solution for everyone, just the best default solution for most. Right now, the default syncs all, and then advanced users can remove that and sync more of a one to one relationship. Any ideas on a better approach are welcome...

Anything I could come up with is just so convoluted and complex.

@dragotin
Copy link
Contributor

dragotin commented May 5, 2015

ok, TODO:

  • If the entire ownCloud is synced, disable the Add folder... button
  • if the Add folder... button is disabled, add a mouse-over text saying "You are already syncing all server folders with this client." Maybe add the local folder name to that message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants