Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Removing local copy of non-previewable file leads to empty view #4428

Open
jesmrec opened this issue Jun 21, 2024 · 9 comments
Open

[BUG] Removing local copy of non-previewable file leads to empty view #4428

jesmrec opened this issue Jun 21, 2024 · 9 comments

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Jun 21, 2024

Steps to reproduce

  1. Click on a non-previewable** file (like an office file) -> downloaded in Details view
  2. In Details view, click on three-dot-button and Remove
  3. Select Local only

Actual behaviour

empty view like:

Screen_recording_20240621_145436.mp4

Expected behaviour

behaviour when a previewable file is deleted, move back to the list of files:

Screen_recording_20240621_145522.mp4

** after some testing, i guess that the difference comes from the previewability of the file, but i can not assure it at all

@jesmrec jesmrec added this to the 4.4 - Future milestone Jun 21, 2024
@jesmrec jesmrec changed the title [BUG] Remove local copy of non-previewable file leads to empty view [BUG] Removing local copy of non-previewable file leads to empty view Jun 21, 2024
@rohit9625
Copy link

May I work on this issue?

@jesmrec
Copy link
Collaborator Author

jesmrec commented Sep 10, 2024

go ahead @rohit9625

@rohit9625
Copy link

Thank you :)

@jesmrec
Copy link
Collaborator Author

jesmrec commented Sep 10, 2024

Let us know if you need any help. Please, take a look to our CONTRIBUTING file to get some guidelines about the way to send the PR.

Pay special attention to the branch names, commit names (following conventional commits) and finally, to the calens file that will add your contribution to the product changelog.

Thanks a lot!

@rohit9625
Copy link

The app asked me to enter a URL. Are there any developer-specific URLs or do I need to create my own server?

@jesmrec
Copy link
Collaborator Author

jesmrec commented Sep 10, 2024

@rohit9625 use the ones mentioned here:

#4435 (comment)

@rohit9625
Copy link

Thank you @jesmrec
I tried with demo server and reproduced the bug successfully. Looking for a fix

@rohit9625
Copy link

Hey @jesmrec
I found the current behavior very unreliable. Sometimes deleting an image doesn't close the details fragment but sometimes it does close it and navigate to the list of files fragment. Same for non-previewable doc files.
Did you ever experience the same behavior?
However, after debugging through breakpoints, I did not find any code that could be causing this bug. Please let me know if you have any specific files to check.

@jesmrec
Copy link
Collaborator Author

jesmrec commented Sep 11, 2024

I found the current behavior very unreliable. Sometimes deleting an image doesn't close the details fragment but sometimes it does close it and navigate to the list of files fragment. Same for non-previewable doc files.
Did you ever experience the same behavior?

yes, behaviour is not exact. I clarified it in the bottom of the top message, like:

** after some testing, i guess that the difference comes from the previewability of the file, but i can not assure it at all

Specific files, i did not test with specific files, just separating previewable / non-previewable, and guessing that the behaviour goes in that direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants