Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Improvements in preview/thumbnails updates #3024

Closed
6 of 8 tasks
jesmrec opened this issue Nov 25, 2020 · 1 comment · Fixed by #3035
Closed
6 of 8 tasks

[FEATURE REQUEST] Improvements in preview/thumbnails updates #3024

jesmrec opened this issue Nov 25, 2020 · 1 comment · Fixed by #3035
Assignees
@abelgardep
Labels
Estimation - 3 (M) Feature request p2-high Escalation, on top of current planning, release blocker
Milestone
2.16

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 25, 2020 •
edited
Loading

Current behaviour:

  • The preview of an txt file is updated only when it is not downloaded, and the containing folder is browsed back and forth.

  • In case the file is downloaded, the preview is not updated because it is generated locally. That means, preview does not match with file content.

ACs

  • When a file is updated in remote (web or other client), the preview will be updated in the following refresh. (this behaviour is pretty similar to the av. offline files one)

  • When a folder contains many files, requests should be scoped / reduced to avoid request-flooding in some way. -> Current behaviour: fetching previews of the files in the screen (pending to confirm)

TASKS

  • Research (if needed)
  • Create branch feature/improve_thumbnails
  • Development tasks
    • Retrieve thumbnails even if the file is available locally
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/improve_thumbnails into master

PR
@jesmrec jesmrec mentioned this issue Nov 25, 2020
Merged
3 tasks
@jesmrec jesmrec added this to the 2.16-current milestone Nov 26, 2020
@jesmrec jesmrec added p2-high Escalation, on top of current planning, release blocker Estimation - 3 (M) labels Nov 26, 2020
@jesmrec
Copy link
Collaborator Author

jesmrec commented Dec 4, 2020 •
edited
Loading

Important topic: #2926 (comment)

Check how does it affect, when a smaller thumbnail size is fetched

@abelgardep abelgardep self-assigned this Dec 15, 2020
@abelgardep abelgardep mentioned this issue Dec 15, 2020
Merged
@abelgardep abelgardep linked a pull request Dec 16, 2020 that will close this issue
Improve thumbnails #3035
Merged
@jesmrec jesmrec added the Sprint label Jan 12, 2021
@jesmrec jesmrec removed the Sprint label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelgardep abelgardep

Labels
Estimation - 3 (M) Feature request p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
2.16
Development

Successfully merging a pull request may close this issue.

Improve thumbnails owncloud/android
2 participants
@jesmrec @abelgardep