Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request previews for EVERY file type #2927

Closed
michaelstingl opened this issue Aug 10, 2020 · 1 comment · Fixed by #3017 or #3105
Closed

Request previews for EVERY file type #2927

michaelstingl opened this issue Aug 10, 2020 · 1 comment · Fixed by #3017 or #3105
Labels
Estimation - 2 (S) Feature request
Milestone
2.17

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented Aug 10, 2020 •
edited by abelgardep
Loading

I assume there's a hardcoded list of filetypes where the Android app requests thumbnails/previews. Depending on the server setup, previews for more file types can be provided. The only way to make sure the Android app shows previews for all files the server supports, is to request previews for EVERY file type. Android app will receive 404 in case there is no preview. (same approach as in new iOS app and in Phoenix web UI)

In the future, server-side could announce in the Capabilities what file types have previews: owncloud/core#31267 (not implemented yet)

PR Old

App #3017

PR New

App #3105
@michaelstingl michaelstingl added this to the 2.16-current milestone Sep 30, 2020
@abelgardep abelgardep linked a pull request Nov 13, 2020 that will close this issue
Use public preview api to retrieve thumbnails #3017
Merged
3 tasks
@abelgardep abelgardep mentioned this issue Nov 13, 2020
Merged
3 tasks
@jesmrec jesmrec reopened this Jan 22, 2021
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 22, 2021

Need to be re-enabled and re-checked in 2.17

@jesmrec jesmrec removed the Sprint label Jan 22, 2021
@jesmrec jesmrec modified the milestones: 2.16-current, 2.17-next Jan 22, 2021
@abelgardep abelgardep mentioned this issue Feb 16, 2021
Merged
@abelgardep abelgardep linked a pull request Feb 16, 2021 that will close this issue
Request thumbnails for every file type #3105
Merged
@jesmrec jesmrec removed the Sprint label Mar 5, 2021
@michaelstingl michaelstingl mentioned this issue Jan 30, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimation - 2 (S) Feature request
Projects
None yet
Milestone
2.17
2 participants
@michaelstingl @jesmrec