Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New arch] Fetch list of files of an specific path #2873

Closed
15 of 17 tasks
jesmrec opened this issue Apr 30, 2020 · 2 comments · Fixed by #2918
Closed
15 of 17 tasks

[New arch] Fetch list of files of an specific path #2873

jesmrec opened this issue Apr 30, 2020 · 2 comments · Fixed by #2918
Assignees
@abelgardep
Labels
Estimation - 5 (L) New architecture
Milestone
3.0 - Synchroniza...

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 30, 2020 •
edited
Loading

Synchronization epic: #2818

  • Once a folder is browsed, list of files is fetched. Important data:

    • File name
    • Extension (to set a thumbnail)
    • Size
    • Date
    • Permissions?
    • Private/Universal link (if included in the response)
    • ...

Improvement

  • Remove individual Get Quota operation and use the quota retrieved in root propfind instead

TASKS

  • Research (if needed)
  • Create branch new_arch/fetch_list_files
  • Development tasks
    • Create new domain model OCFile
    • Add refresh files usecase
    • Migrate RemoteOperation to kotlin
    • Add function to FilesRepository
    • Implement FilesRemoteDatasource
    • Implement FilesLocalDatasource
    • Create OCFileEntity and Dao
    • Add tests on domain module
    • Add tests on data module [Not completed because it requires changes]
    • Handle basic conflicts
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch new_arch/fetch_list_files into master

PR
@abelgardep abelgardep self-assigned this Jun 24, 2020
This was referenced Jul 8, 2020
Merged
Merged
@jesmrec jesmrec linked a pull request Jul 20, 2020 that will close this issue
[New arch] Fetch list of files #2918
Merged
@davigonz davigonz mentioned this issue Jul 28, 2020
Closed
75 tasks
@jesmrec jesmrec removed the Sprint label Jul 31, 2020
@michaelstingl
Copy link
Contributor

  • Extension (to set a thumbnail)

New iOS app just asks for thumbnail for EVERY file type… (plenty of 404)

This might help in the future: owncloud/core#31267

I'd avoid hardcoded list of file types that support preview generation.

@jesmrec
Copy link
Collaborator Author

jesmrec commented Aug 5, 2020

We will not forget it... right now, only asking for picture thumbnails.

@abelgardep abelgardep mentioned this issue Aug 12, 2020
Merged
@jesmrec jesmrec closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelgardep abelgardep

Labels
Estimation - 5 (L) New architecture
Projects
None yet
Milestone
3.0 - Synchronization milestone
Development

Successfully merging a pull request may close this issue.

[New arch] Fetch list of files owncloud/android
3 participants
@michaelstingl @jesmrec @abelgardep