Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title on top bar in upload View is shown sometimes owncloud instead of Uploads #1524

Closed
nasli opened this issue Mar 16, 2016 · 16 comments
Closed

Comments

@nasli
Copy link

nasli commented Mar 16, 2016

Expected behaviour

The title does not change

Actual behaviour

Uploads title change to "ownCloud" and we are still on the uploads view

Steps to reproduce

  1. Tap on left button menu and select uploads
  2. Tap on the left button menu
  3. You do not select any option in the lateral menu and came back to uploads view

Environment

Nexus 5, v5

@LukeOwlclaw
Copy link

Note: Uploads view show menu button at top left corner. The other views (settings and protocol) show a left arrow.

If also in the uploads view an arrow was shown, this issue would probably be resolved?! Plus: Consistent behavior within the app.

@LukeOwlclaw
Copy link

Note 2 : It can even happen that a photo filename is displayed as title. I am not quite sure how to reproduce. I was clicking on current, failed, and completed upload items. Then menu button and back, as described by nasli. Then title was IMG_....jpg.

@nasli
Copy link
Author

nasli commented Mar 17, 2016

I rather left this behaviour for all the views, and only change to the files list view if the user tap over Files in the menu.

About Note2, we are aware of that but same here, thanks for checking @LukeOwncloud !

@AndyScherzinger
Copy link
Contributor

At the moment I would ague to go for the arrow since you basically switch to another "context" and want to navigate back.

In the future via @tobiasKaminsky work we will also be able to have filters in the drawer like "offline files" where you stay in the same context. So you will still have the drawer but that is another thing. Having the drawer on all screens has been discussed between @jancborchardt and me and we decided to stick with the arrow.

Hope that helps :)

@nasli
Copy link
Author

nasli commented Mar 17, 2016

@LukeOwncloud , note2 catch out! #1530

@malkomich
Copy link
Member

@AndyScherzinger the arrow style in the action bar implies that you want to go back in the navigation, like when you back to a parent folder for instance.
The burguer menu is wished to be used If the user wants to change the context of the application going to a different view like in this case.
Also, the arrow is being used for setting view because this view is a special one in Android which have a different inheritance flow, but for the rest of views the burguer menu would be more meaningful for a navigation bar.

@AndyScherzinger
Copy link
Contributor

@malkomich that is true, the question is what is more expected by the user, to navigate somewhere else, or to navigate back/up simply because flow wise navigating somewhere else even if it is the main file list (can) add(s) to the navigational stack for back navigation. Both things work imho but I am not an UX expert as to what is the users expectation here. @jancborchardt any input here? 😃

Just checked the play store navigation and that one works as described by @malkomich and also like it is now for the upload view.

@nasli
Copy link
Author

nasli commented Mar 17, 2016

As an user, I would like a menu, and go home only if I tap on it

@LukeOwlclaw
Copy link

Works for me now. 👍

@davivel
Copy link
Contributor

davivel commented Mar 17, 2016

As already said, the "Google pattern" prefers the burger menu for any activity that offers navigation drawer and appears as a top-level option in it. Settings view is an exception to the pattern (for us and for any app with it, check yourself), mainly because settings activities tipically inherit from http://developer.android.com/intl/es/reference/android/preference/PreferenceActivity.html , while activities with navigation drawer inherit from http://developer.android.com/intl/es/reference/android/support/v7/app/AppCompatActivity.html, and Java doesn't support multiple inheritance.

The "logs" activity ( @LukeOwncloud , you mean that with "protocol", right? ) should not be taken as a reference, since it was built just-for-developer-eyes , and is not specially careful with design guidelines.

@davivel
Copy link
Contributor

davivel commented Mar 17, 2016

Note 2 : It can even happen that a photo filename is displayed as title

I think that's #1530, should be fixed now too.

@AndyScherzinger
Copy link
Contributor

The "logs" activity ( @LukeOwncloud , you mean that with "protocol", right? ) should not be taken as a reference, since it was built just-for-developer-eyes , and is not specially careful with design guidelines.

Exactly, that one should stay that way especially since #1432 will lead to the logs item being moved to the settings like version number etc. and than the back/up arrow would be the right thing again 😃

@nasli
Copy link
Author

nasli commented Mar 18, 2016

👍 We can close this issue

@jancborchardt
Copy link
Member

@AndyScherzinger just to clarify what the expectation would be:

  • If I’m in »All files«, the title says »ownCloud« and there’s the menu icon on the top left
  • If I’m in »On device« or »Uploads« the title should reflect that of course! Also, ideally there should be the menu icon on the top left triggering the menu. From a user perspective, these are not entirely different »views«, it’s just a filter on the same stuff. So the rest of the interface should behave the same!
  • If I’m in »Settings« the title should of course be »Settings« as well. It’s fine to have the back button since it’s not a file list, but in an ideal world where I don’t care about the technical and platform conventions, the settings view would be in the content area exactly like the other ones. ;)

TL;DR: Even though the content changes, the interface like top bar (except the right side tools), sidebar etc should stay consistent in some way.

@AndyScherzinger
Copy link
Contributor

@jancborchardt sounds perfectly fine to me :) Besides this is imho how it is implemented at the moment is it not?

@davivel
Copy link
Contributor

davivel commented Mar 29, 2016

It is. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants