-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append etag in preview URLs #369
Comments
No, that's abuse against caching. If the valid preview URL returns a wrong image, that is something core has to deal with! |
Using the etag isn't abuse. We do that in the files app too. |
(a random string is abuse, yes) |
Well, currently we don't have the etag. Maybe as part of chaning previews to file id way |
Isn't the preview URL bundled in a field ? You could just append the etag there. |
No it is currently generated from the file path. But that means when it is moved we don't have previews anymore, so changing that is maybe a good idea anyway. |
I got a case where the URL returned by the activity app was showing the wrong cached preview from an older version of the file.
Ideal would be to either append a random string "c=1a2b3c4d5" in the URL or the etag.
The text was updated successfully, but these errors were encountered: