Append etag in preview URLs

[PVince81]

I got a case where the URL returned by the activity app was showing the wrong cached preview from an older version of the file.

Ideal would be to either append a random string "c=1a2b3c4d5" in the URL or the etag.

[nickvergessen]

No, that's abuse against caching. If the valid preview URL returns a wrong image, that is something core has to deal with!

[PVince81]

Using the etag isn't abuse. We do that in the files app too.
So as long as the file is the same as before, it will use the cached image from the browser as it has the same etag.
If the etag changes, a new preview is requested.

[PVince81]

(a random string is abuse, yes)

[nickvergessen]

Well, currently we don't have the etag. Maybe as part of chaning previews to file id way

[PVince81]

Isn't the preview URL bundled in a field ? You could just append the etag there.

[nickvergessen]

No it is currently generated from the file path. But that means when it is moved we don't have previews anymore, so changing that is maybe a good idea anyway.