This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
[WIP] Move MetaData and Group selector to core #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the MetData file and Group selector code to core. Signed-off-by: Sujith H <[email protected]>
10 tasks
|
Current state of the PR
|
really? this class is 💩 - whatfor you need this in core? I prefer to have a different solution |
DeepDiver1975
suggested changes
Nov 6, 2018
| @@ -25,7 +25,7 @@ | |||
| namespace OCA\UserManagement\Controller; | |||
|
|
|||
| use OC\AppFramework\Http; | |||
| use OCA\UserManagement\MetaData; | |||
| use OC\MetaData; | |||
There was a problem hiding this comment.
You are not allowed to use private classes in apps ...
| * @param int $sortGroups | ||
| * @return DataResponse | ||
| */ | ||
| public function index($pattern = '', $filterGroups = false, $sortGroups = MetaData::SORT_USERCOUNT) { |
There was a problem hiding this comment.
this is part of the rest full api - I don't get the need of this ....
|
@sharidas please post context... why is this PR needed ? etc |
|
@DeepDiver1975 Sure I will come up with an alternative solution. |
keep user mgmt untouched and add a new controller in core |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the MetData file and Group selector
code to core.
Signed-off-by: Sujith H [email protected]