-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 (slope) feature parity with line charts / TAS-708 #4192
Open
sophiamersmann
wants to merge
46
commits into
master
Choose a base branch
from
redesign-slopes-viz
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,018
−1,296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sophiamersmann
force-pushed
the
grapher-refactor-types
branch
from
November 20, 2024 16:42
83a3c4e
to
f0a16e0
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 20, 2024 16:42
366df89
to
b563e66
Compare
sophiamersmann
force-pushed
the
grapher-refactor-types
branch
from
November 20, 2024 16:44
f0a16e0
to
85b4436
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 20, 2024 16:44
b563e66
to
7f7555e
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 26 (e6891d) ❌ Edited: 2024-11-29 16:04:27 UTC |
sophiamersmann
force-pushed
the
grapher-refactor-types
branch
from
November 20, 2024 17:10
85b4436
to
75fa3c6
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 20, 2024 17:10
7f7555e
to
a5147be
Compare
sophiamersmann
force-pushed
the
grapher-refactor-types
branch
from
November 21, 2024 11:21
75fa3c6
to
eb80785
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 21, 2024 11:22
a5147be
to
18f0a85
Compare
sophiamersmann
changed the title
✨ (slope) redesign
✨ (slope) feature parity with line charts
Nov 21, 2024
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 21, 2024 11:26
18f0a85
to
2fbdef5
Compare
9 tasks
sophiamersmann
force-pushed
the
grapher-refactor-types
branch
2 times, most recently
from
November 21, 2024 12:57
d5cc21b
to
0e247d5
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 21, 2024 12:57
2fbdef5
to
1de90ae
Compare
sophiamersmann
changed the title
✨ (slope) feature parity with line charts
🎉 (slope) feature parity with line charts
Nov 21, 2024
sophiamersmann
force-pushed
the
grapher-refactor-types
branch
from
November 22, 2024 08:03
0e247d5
to
4d99b3b
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 22, 2024 10:14
1de90ae
to
1f645df
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 22, 2024 13:15
196784f
to
96236e6
Compare
sophiamersmann
changed the title
🎉 (slope) feature parity with line charts
🎉 (slope) feature parity with line charts / TAS-708
Nov 22, 2024
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 22, 2024 15:02
96236e6
to
f63bed0
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 22, 2024 16:01
f63bed0
to
1b31ea6
Compare
6 tasks
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 29, 2024 15:11
65a79e7
to
2cd787d
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 29, 2024 15:33
2cd787d
to
cdd952f
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 29, 2024 15:35
cdd952f
to
7e583e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds line chart features to slope charts.
Designs are implemented in a later PR. For now, I removed all custom rendering logic and used the line chart's line legend for labelling. The details of the layout, the slope style, the entity and value labels will change in a future PR, so no need to review the rendering. This also includes rendering bugs like dots overflowing, misaligned labels, etc.
Summary
Might be addressed later
Not addressed
Testing
I enabled slope tabs for all line charts on staging for testing.
Example charts:
Bugs