Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon doesn't work after resuming the machine from suspend state #22

Open
bodiroga opened this issue Nov 23, 2016 · 8 comments
Open

Addon doesn't work after resuming the machine from suspend state #22

bodiroga opened this issue Nov 23, 2016 · 8 comments

Comments

@bodiroga
Copy link

Hi Oliver!

Great job with the addon, works great and it's an easy way to integrate Kodi with any system that speaks Mqtt. Congratulations!

I don't know if I'm the only one, but in my Kodi installation (custom made HTPC with Libreelec) the addon doesn't work after resuming the machine from the suspend state (S3). It doesn't publish the "connected" message and I don't see no message being published when some video is played. Is it a normal behavior? If it's not, I will try to collect some useful debug log files for you.

Many again for your help and keep up with the great work.

Best regards,

Aitor

@bodiroga
Copy link
Author

bodiroga commented Dec 2, 2016

I have been doing some more tests and now it seems to be sending playback messages fine, but I haven't changed anything. Anyway, the "connected" message wasn't being sent after resume and to fix it I have moved the "mqc.publish(topic+"connected",2,qos=1,retain=True)" call to the connectHandler function. For me, it makes more sense to place that call in the connectHandler, because it will be called just when the client is connected to the broker, so we can be sure that the publish method will not fail.

I will provide a PR soon, because it's a couple line change.

Best regards,

Aitor

@bodiroga
Copy link
Author

bodiroga commented Dec 2, 2016

Done: #23

@gahujipo
Copy link

Done: #23

this should definitely be merged. With this change the add-on works much better. I verified it with the windows store app.

@eschava
Copy link

eschava commented Oct 31, 2019

I've tried to accept pull request for this (and some other issues) and published a 0.14 release under my fork at
https://github.com/eschava/kodi2mqtt/releases/tag/0.14

@gahujipo
Copy link

@eschava this is great. finally the first publish after the playback starts works; that's amazing. Would you think about enabling the issues on your forked repo?

@eschava
Copy link

eschava commented Nov 13, 2019

Sure, why not? Actually I didn't know that issues are disabled by default :)
Done already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@eschava @bodiroga @gahujipo and others