Use existing library for filtering files using glob patterns #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,8 @@ task extractNativeBundle(type: Copy) { | |||
|
|
|||
| buildscript { | |||
| repositories { | |||
| if (project.hasProperty('local')) mavenLocal() | |||
| // if (project.hasProperty('local')) | |||
There was a problem hiding this comment.
Has to be uncommented once the patch has been reviewed and tested
lpellegr
changed the title
…atterns Make use of the new implementation introduced in programming for file selection. One important change is about the PatternType class introduced to convert old blob types to the correct object type used with the current version of the product.
|
We have discussed about that with Fabien and it seems better to keep the name as it is to prevent any issue with executing code that relies on this class. |
lpellegr
added a commit
that referenced
this pull request
May 26, 2015
Use existing library for filtering files using glob patterns
|
That is going to be an interesting one to merge with Speed branch :D |
This was referenced Jun 12, 2015
fviale
added a commit
that referenced
this pull request
Oct 26, 2016
- removed hard-coded file encoding - implemented suggestions. - added utf-8 file-encoding to unit test configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked with ow2-proactive/programming#1