Migrate to Gaia v3.0 #278

jackzampolin · 2020-08-27T01:07:57Z

Current Status: #281

jackzampolin · 2020-08-27T01:08:46Z

make test-gaia pulls the latest build of gaiav3.0 branch.

zmanian · 2020-08-27T01:57:37Z

You have local replace directives in the go.mod FYI

jackzampolin · 2020-08-30T17:37:21Z

Ok, so this branch is now compiling and running a developer environment with ./dev-env. Due to the changes there are some significant refactors that need to be undertaken. Below is the planned order:

Lite client initialization - the lite client isn't initializing properly. Need to debug this.
Submitting transactions is currently broken.
Refactor connection handshake messages - the arguments changed substantially here and make take some work to get right.
Packet Commitment sequences - This code has changed considerably. The previous version required a good deal of relayer side code where as the new version has a more streamlined flow.
Packet relaying - this flow has changed considerably and previously relied on a type in the relayer. Need to figure out the new flow.

jackzampolin · 2020-09-01T23:21:14Z

Ok to reproduce the current error make sure you have gaia checked out to jack/gaiav3.0 and run ./dev-env skip from the root of this repo.

$ ./dev-env skip
Generating gaia configurations...
Creating gaiad instance with home=./data chain-id=ibc0 p2p=:26656 rpc=:26657...
Creating gaiad instance with home=./data chain-id=ibc1 p2p=:26556 rpc=:26557...
Building Relayer...
installing rly binary...
Generating rly configurations...
added path demo...
added chain ibc0...
added chain ibc1...

Key cosmos1h3jlfsfhp3hqp8tfnf2gmcqnaj0msrnpmefwpe imported from ibc0 to relayer...
Key cosmos104gh7dqzy6gpr05sytdqttyzc6l3z6ppfswkpn imported from ibc1 to relayer...

Creating lite clients...

I[2020-09-01|16:20:50.313] - [ibc0] -> creating client (ibconeclient) for [ibc1]header-height{9} trust-period(336h0m0s) 
I[2020-09-01|16:20:50.341] - [ibc1] -> creating client (ibczeroclient) for [ibc0]header-height{9} trust-period(336h0m0s) 
I[2020-09-01|16:20:50.361] - [ibc0] -> sending transaction:             
I[2020-09-01|16:20:50.361] ✘ [ibc0]@{0} - msg(0:create_client) err(sdk:2:Mismatched "*ics23.InnerSpec": {TagNum: 1, GotWireType: "bytes" != WantWireType: "varint"}: tx parse error) 
I[2020-09-01|16:20:50.361] - transaction response:                      
{"txhash":"0963B2FD26C149A4B3A67695259B1A3E4FC93EE5A13088D0DE52ABC68E7C8E5B","codespace":"sdk","code":2,"raw_log":"Mismatched \"*ics23.InnerSpec\": {TagNum: 1, GotWireType: \"bytes\" != WantWireType: \"varint\"}: tx parse error","logs":null}
I[2020-09-01|16:20:50.381] - [ibc1] -> sending transaction:             
I[2020-09-01|16:20:50.381] ✘ [ibc1]@{0} - msg(0:create_client) err(sdk:2:Mismatched "*ics23.InnerSpec": {TagNum: 1, GotWireType: "bytes" != WantWireType: "varint"}: tx parse error) 
I[2020-09-01|16:20:50.381] - transaction response:                      
{"txhash":"EBD5E08670461C8FD2B125AFD5C8CA190E2A9B2E9D7093FF78FF0033140B6274","codespace":"sdk","code":2,"raw_log":"Mismatched \"*ics23.InnerSpec\": {TagNum: 1, GotWireType: \"bytes\" != WantWireType: \"varint\"}: tx parse error","logs":null}
Error: err: cannot proto marshal <nil>: failed packing protobuf message to Any [cosmos/[email protected]/x/ibc/02-client/types/codec.go:62]

Blocked on cosmos/cosmos-sdk#7211

…aiav3.0

AdityaSripal · 2020-09-10T19:25:26Z

relayer/naive-strategy.go

@@ -432,7 +432,8 @@ func relayPacketFromQueryResponse(src, dst *PathEnd, res *ctypes.ResultTx,
 					rp.packetData = []byte(p.Value)
 				}
 				if string(p.Key) == "packet_timeout_height" {
-					timeout, _ := strconv.ParseUint(strings.Split(string(p.Value), "-")[0], 10, 64)
+					fmt.Println("TIMEOUT HEIGHT VALUE:", string(p.Value))
+					timeout, _ := strconv.ParseUint(strings.Split(string(p.Value), "-")[1], 10, 64)
 					rp.timeout = timeout


NOTE: rp.timeout should eventually become a clienttypes.Height struct

is there an open issue on the SDK for this? Do we need to track this workstream somewhere?

This is already done in the SDK, this is a relayer issue. I mean that the relayer structs like relayMsgRecvPacket and relayMsgTimeout still use a uint64 to represent timeout height. The SDK uses clienttypes.Height and the relayer currently hacks around this by getting the epoch height from the sending chain like so:

https://github.com/ovrclk/relayer/blob/jack%2Fgaiav3.0/relayer/naive-strategy.go#L434

And then recreating a clienttypes.Height for the receiving chain like so:

https://github.com/ovrclk/relayer/blob/jack%2Fgaiav3.0/relayer/relayPackets.go#L162

Instead, the relayer structs should have timeoutHeight be a clienttypes.Height struct and then simply parse the height from the events and place the clienttypes.Height in the relayer struct. Then the full height with the epoch number can be sent to the receiving chain.

This would allow the relayer to work for chains with non-zero epochs

…aiav3.0

jackzampolin · 2020-09-17T00:24:44Z

Once the issue with rly start {path} not receiving transaction notifications is fixed, will merge this branch into master.

WIP: not compiling, some errors fixed

7c7b34a

jackzampolin added 7 commits August 27, 2020 12:07

s/iqlusioninc/ovrclk/g

90ebd23

s/iqlusioninc/ovrclk/g

51526bc

WIP: continued debugging, not close to compiling

f526201

WIP query migration to new cliContext

4205283

Compiler errors in /relayer

ab62a71

COMPILING

dd19d03

Reimplement connection messages

7e5029f

jackzampolin added 3 commits August 30, 2020 12:11

Refactor two-chainz to call one-chain and get dev-env working again

9c04ca5

Fix lite client wip client transactions

0dad18e

Update to latest SDK and refactor create client msgs

1dcd598

Working client creation

acf795d

michaelfig mentioned this pull request Sep 3, 2020

Stargate upgrade Agoric/agoric-sdk#1634

Merged

4 tasks

jackzampolin and others added 13 commits September 4, 2020 07:36

Pull in latest sdk

97553d5

Update relayer to latest version of sdk

a7caf16

Prepare to fix update-client

d1b253e

add inject fields method

5a6b12f

fix godoc

e3018a3

fix UpdateClient

85e4593

fix clientstate bug

4d441eb

Update to latest sdk

0147938

Update to latest sdk

98785d0

Concurrency refactor and query refactor

25b9e0c

Latest debugging

233bd55

remove unused code

9e0a9f2

fix TRY query

3144e72

AdityaSripal added 2 commits September 10, 2020 15:20

fix timeout issue

eea8044

Merge branch 'jack/gaiav3.0' of github.com:ovrclk/relayer into jack/g…

5e45a77

…aiav3.0

AdityaSripal reviewed Sep 10, 2020

View reviewed changes

jackzampolin and others added 20 commits September 11, 2020 10:29

WORKING STATE 🎉

17eb4fe

Fix gaia test, prepare for cleanup

53d9e2d

Push current state

84c9407

Fix chain starting issue

29f781f

lite -> light

947a964

Working state

135b46a

WIP denom support

2ad2922

fix querying unrelayed sequences

853f595

Merge branch 'jack/gaiav3.0' of github.com:ovrclk/relayer into jack/g…

34db59c

…aiav3.0

cleanup

dc7815a

simplify further

f414186

remove commented-out code

ea145db

Added query for IBC denoms

692443a

Merge branch 'jack/gaiav3.0' of github.com:ovrclk/relayer into jack/g…

f12e019

…aiav3.0

Update sdk version to incorporate IBC fixes

7b17082

lint cleanup

00fdbb3

Remove old compatable chains, they will need to be re-added

b915e5e

Fix linter version in CI

acdb1d1

Clean up chain fields

144de6c

fix lint

fa1feca

jackzampolin added 4 commits September 17, 2020 12:35

add human readable IBC denoms to bal output

6e09550

Update sdk version

9ee0dee

Ensure that balance prints when there are no ibc transactions

36cdf04

jack/gaiav3.0

74a2774

jackzampolin merged commit 372bbfb into master Sep 21, 2020

jackzampolin deleted the jack/gaiav3.0 branch September 21, 2020 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Gaia v3.0 #278

Migrate to Gaia v3.0 #278

jackzampolin commented Aug 27, 2020 •

edited

Loading

jackzampolin commented Aug 27, 2020

zmanian commented Aug 27, 2020

jackzampolin commented Aug 30, 2020 •

edited

Loading

jackzampolin commented Sep 1, 2020 •

edited

Loading

AdityaSripal Sep 10, 2020

jackzampolin Sep 11, 2020

AdityaSripal Sep 12, 2020

AdityaSripal Sep 12, 2020

jackzampolin commented Sep 17, 2020

Migrate to Gaia v3.0 #278

Migrate to Gaia v3.0 #278

Conversation

jackzampolin commented Aug 27, 2020 • edited Loading

jackzampolin commented Aug 27, 2020

zmanian commented Aug 27, 2020

jackzampolin commented Aug 30, 2020 • edited Loading

jackzampolin commented Sep 1, 2020 • edited Loading

AdityaSripal Sep 10, 2020

Choose a reason for hiding this comment

jackzampolin Sep 11, 2020

Choose a reason for hiding this comment

AdityaSripal Sep 12, 2020

Choose a reason for hiding this comment

AdityaSripal Sep 12, 2020

Choose a reason for hiding this comment

jackzampolin commented Sep 17, 2020

jackzampolin commented Aug 27, 2020 •

edited

Loading

jackzampolin commented Aug 30, 2020 •

edited

Loading

jackzampolin commented Sep 1, 2020 •

edited

Loading