Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovh_domain_zone_record: Make fieldtype non-updatable #84

Merged
merged 2 commits into from
Apr 18, 2019

Conversation

radeksimko
Copy link
Contributor

Tests without patch:

make testacc TEST=./ovh TESTARGS='-run=TestAccOvhDomainZoneRecord_updateType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ovh -v -run=TestAccOvhDomainZoneRecord_updateType -timeout 120m
=== RUN   TestAccOvhDomainZoneRecord_updateType
--- FAIL: TestAccOvhDomainZoneRecord_updateType (12.17s)
    testing.go:538: Step 1 error: Error applying: 1 error(s) occurred:

        * ovh_domain_zone_record.foobar: 1 error(s) occurred:

        * ovh_domain_zone_record.foobar: Failed to update OVH Record: Error 400: "Try to alter read-only properties: fieldType"
FAIL
FAIL	github.com/terraform-providers/terraform-provider-ovh/ovh	12.194s
make: *** [testacc] Error 1

with patch:

make testacc TEST=./ovh TESTARGS='-run=TestAccOvhDomainZoneRecord_updateType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ovh -v -run=TestAccOvhDomainZoneRecord_updateType -timeout 120m
=== RUN   TestAccOvhDomainZoneRecord_updateType
--- PASS: TestAccOvhDomainZoneRecord_updateType (12.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ovh/ovh	12.167s

@ghost ghost added the size/M label Apr 8, 2019
@radeksimko radeksimko requested review from yanndegat and a team April 14, 2019 15:32
@radeksimko radeksimko merged commit d9fb949 into master Apr 18, 2019
@radeksimko radeksimko deleted the b-dns-rec-type-update branch April 18, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants