Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixdomaintestacc #77

Merged
merged 5 commits into from
Mar 7, 2019
Merged

Fixdomaintestacc #77

merged 5 commits into from
Mar 7, 2019

Conversation

yanndegat
Copy link
Collaborator

  • add http debug logger
  • r/domain_zone_redirection: log refresh errors as warn
  • r/domain_zone_redirection: test prefix with random string
  • r/domain_zone_record: test prefix with random string
  • r/domain_zone_record: handle inconsistent known OVH API response

@ghost ghost added the size/L label Mar 4, 2019
@yanndegat yanndegat requested a review from radeksimko March 4, 2019 14:50
@ghost ghost added dependencies and removed size/L labels Mar 5, 2019
radeksimko
radeksimko approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ovh/config.go Outdated Show resolved Hide resolved
ovh/resource_ovh_domain_zone_record.go Show resolved Hide resolved
@ghost ghost added size/L and removed size/XXL labels Mar 6, 2019
radeksimko
radeksimko reviewed Mar 6, 2019
View reviewed changes
Copy link
Contributor

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing left now is to run go mod vendor to vendor any dependency changes - that is IMO why tests in Travis are currently failing.

@ghost ghost added size/XXL and removed size/L labels Mar 6, 2019
@radeksimko radeksimko merged commit 430a0c8 into ovh:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanndegat @radeksimko