This repository has been archived by the owner on Aug 7, 2020. It is now read-only.
feat: use new navbar #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolitec
force-pushed
the
feature/newNavbar
branch
from
a601963 to
8c5a784
Compare
AxelPeter
approved these changes
May 16, 2018
This was referenced May 17, 2018
|
I've added the possibility to have a title next the logo brand with the linked PRs |
FredericEspiau
approved these changes
May 17, 2018
| } | ||
|
|
||
| if (this.secondLevelsChildren[state].children.undefined) { | ||
| subLinks.push(...this.getLinks(state, "undefined")); |
| } | ||
|
|
||
| (this.secondLevelsChildren[state].groupsOrder || []).forEach(groupName => { | ||
| if (groupName === "undefined") { |
There was a problem hiding this comment.
Why use a string ? Can't you use a true undefined (or even better, null) ?
whispyy
approved these changes
May 17, 2018
AxelPeter
pushed a commit
that referenced
this pull request
May 18, 2018
* feat: use new navbar * style(oui-navbar): add brand title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new UI-Kit navbar component
Linked to
ovh-ux/ovh-ui-angular#183
ovh/ovh-ui-kit#207