Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

fix(me.contact): remove apiv7 call #338

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

lizardK
Copy link
Contributor

@lizardK lizardK commented Jun 1, 2022

Signed-off-by: Cyril Biencourt [email protected]

Signed-off-by: Cyril Biencourt <[email protected]>
@lizardK lizardK force-pushed the fix/me-contact-apiv7 branch from 00d0ea6 to dae319d Compare June 1, 2022 13:11
@cbourgois
Copy link
Contributor

@ovh-ux ovh-ux deleted a comment from ovh-cds Jun 1, 2022
@antleblanc
Copy link
Contributor

Could we use OvhApiMeContactV6 (https://github.com/ovh-ux/ovh-api-services/blob/master/src/api/me/contact/me-contact.v6.service.js) instead ?

Due to some constraint and to avoid having a large impact, this following approach has been taken into account
but yes, you're right, would be better to use OvhApiMeContactV6 when it comes to APIv6 calls.

Alternative: Already discussed few months ago, but as we're moving out from AngularJS, it might be a good start to deprecate ovh-api-services.

@antleblanc antleblanc merged commit 1420030 into master Jun 2, 2022
@antleblanc antleblanc deleted the fix/me-contact-apiv7 branch June 2, 2022 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants