This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
feat(services): add form routes #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marie JONES <[email protected]>
marie-j
requested review from
antleblanc,
AxelPeter,
cbourgois,
FredericEspiau,
frenautvh,
ganeshkumar1989,
JeremyDec,
Jisay,
jleveugle,
lizardK,
radireddy and
varun257
as code owners
frenautvh
approved these changes
Feb 12, 2020
JeremyDec
approved these changes
Feb 12, 2020
FredericEspiau
approved these changes
Feb 12, 2020
| @@ -0,0 +1,9 @@ | |||
| angular.module('ovh-api-services').service('OvhApiServicesFormV6', ($resource) => $resource('/services/:serviceId/form/:formName', { | |||
There was a problem hiding this comment.
Copy/paste from parent I guess, not entirely sure it is needed as main usage is for this is to open link from email meaning that a new app is started
There was a problem hiding this comment.
It's your usage of it, not all the future usage of it 😱
There was a problem hiding this comment.
Then I guess if cache is needed at one point, it can always be added
antleblanc
approved these changes
Feb 13, 2020
cbourgois
approved these changes
Feb 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.