This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
fix(ai/serving): rework capablities to avoid endpoint shadowing #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XciD
requested review from
antleblanc,
AxelPeter,
cbourgois,
FredericEspiau,
frenautvh,
ganeshkumar1989,
JeremyDec,
Jisay,
jleveugle,
lizardK,
marie-j,
radireddy and
varun257
as code owners
marie-j
previously approved these changes
Jan 27, 2020
FredericEspiau
approved these changes
Jan 28, 2020
JeremyDec
previously approved these changes
Jan 28, 2020
FredericEspiau
previously requested changes
Jan 28, 2020
...capabilities/serving/presetImage/cloud-project-serving-capabilities-stream-region.service.js
Outdated
Show resolved
Hide resolved
...i/capabilities/serving/flavor/cloud-project-serving-capabilities-stream-region.v6.service.js
Outdated
Show resolved
Hide resolved
...abilities/serving/presetImage/cloud-project-serving-capabilities-stream-region.v6.service.js
Outdated
Show resolved
Hide resolved
marie-j
previously approved these changes
Jan 29, 2020
antleblanc
reviewed
Jan 29, 2020
There was a problem hiding this comment.
Thanks @XciD for you contribution.
Maybe you can update the following OvhApiCloudProject service and add Ai():
src/api/cloud/project/cloud-project.service.js
Ai() {
return $injector.get('OvhApiCloudProjectAi');
},Feel free to tell my if you find it relevant for you use case.
On other part these endpoints are currently flagged as Internal.
Do you have any informations about the final release?
Thanks!
|
Hello @antleblanc I've added your recommendation. Yes, they are internal for now, should be open in beta next week. It's possible to merge the PR in order to deploy and test the manager in staging ? |
JeremyDec
approved these changes
Jan 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix existing shadowing in /cloud/project/ai/serving/{id} with /cloud/project/ai/serving/capabilities