This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
fix(vps): add cache for available images queries #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyDec
force-pushed
the
fix/vps-images-available-cache
branch
from
5e2acc4 to
f7cc524
Compare
FredericEspiau
approved these changes
Sep 30, 2019
|
It seems to be a feature not a fix right? But why the cache is needed in your case? |
|
I need the cache to avoid the user having to request the api each time the modal is opened. Since it is more a enhancement than a fix, yes it could be a feature instead |
antleblanc
approved these changes
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MANAGER-3074