Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

feat: enterprise cloud database apis #232

Merged
merged 1 commit into from
Sep 27, 2019
Merged

feat: enterprise cloud database apis #232

merged 1 commit into from
Sep 27, 2019

Conversation

ganeshkumar1989
Copy link
Contributor

Addition of APIs for Enterprise Cloud Database

Jisay
Jisay suggested changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@Jisay Jisay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments of Marie and Fred ;-)

@ganeshkumar1989 ganeshkumar1989 force-pushed the feat/enterprise-cloud-database branch from ed7375e to 69284aa Compare September 25, 2019 09:00
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 25, 2019

CDS Report build#1266.0 ✘
*

  • build ✔
  • test ✘

@ganeshkumar1989
Copy link
Contributor Author

See comments of Marie and Fred ;-)

All comments have been addressed. Thanks :)

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 26, 2019

CDS Report build#1273.0 ✘
*

  • build ✔
  • test ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 26, 2019

CDS Report build#1275.0 ✘
*

  • build ✔
  • test ✘

@ganeshkumar1989 ganeshkumar1989 force-pushed the feat/enterprise-cloud-database branch from 2b95bd6 to a7138ca Compare September 26, 2019 09:56
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 26, 2019

CDS Report build#1277.0 ✘
*

  • build ✔
  • test ✘

Jisay
Jisay reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@Jisay Jisay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just have to fix your code for eslint test to be succeful

@ganeshkumar1989 ganeshkumar1989 force-pushed the feat/enterprise-cloud-database branch from a7138ca to 18f1ff3 Compare September 27, 2019 05:32
@ganeshkumar1989
Copy link
Contributor Author

You just have to fix your code for eslint test to be succeful

The ESLint tests have been fixed. Thanks

@Jisay Jisay merged commit 944a193 into master Sep 27, 2019
@Jisay Jisay deleted the feat/enterprise-cloud-database branch September 27, 2019 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeremyDec JeremyDec JeremyDec left review comments

@marie-j marie-j marie-j left review comments

@Jisay Jisay Jisay approved these changes

@FredericEspiau FredericEspiau FredericEspiau requested changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ganeshkumar1989 @ovh-cds @Jisay @FredericEspiau @marie-j @JeremyDec