This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
build: bump to lodash4, use rollup #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenautvh
requested review from
cbourgois,
antleblanc,
jleveugle,
lizardK and
marie-j
frenautvh
force-pushed
the
build/lodash4
branch
6 times, most recently
from
ed2ec28 to
bb0763d
Compare
|
Wouldn't be considered as an Breaking Changes? The |
marie-j
approved these changes
Jul 22, 2019
antleblanc
force-pushed
the
build/lodash4
branch
from
ddba29f to
ab51cfd
Compare
antleblanc
force-pushed
the
build/lodash4
branch
from
1d45f26 to
4221a35
Compare
antleblanc
force-pushed
the
build/lodash4
branch
from
4221a35 to
f4fc372
Compare
uses: `yarn upgrade-interactive --latest` - @ovh-ux/[email protected] - [email protected]
uses: `yarn upgrade-interactive --latest` - [email protected]
Required since ESLint has been updated from v5.16.0 to v6.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note : in order to not have to rewrite the full library with es6 imports, i'm using "rollup-plugin-glob-import" to import all the sources. I think it's a nice workaround because we can already start using imports for future updates and we can still refactor some part of the source code later
Also the eslint config is still the "old" one, i don't plan to update it now, it's not in the scope of this pull request