Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

feat(cloud.logs): iceberg support #151

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

pdepaepe
Copy link
Contributor

Hello,

This PR will allow Iceberg support on Logs Data Platform API.

Thanks for your review, merge & prod time.

Signed-off-by: Pierre De Paepe [email protected]

Signed-off-by: Pierre De Paepe <[email protected]>
@antleblanc
Copy link
Contributor

Thanks @pdepaepe for your contribution.

Do you have any requirements about using theses new services?

Because it seems that Iceberg isn't available for all regions and I'm not 100% sure that it safe to use in production.

@rbeuque74 could probably tell us a bit more about the current status I guess.

@pdepaepe
Copy link
Contributor Author

pdepaepe commented Apr 3, 2019

Do you have any requirements about using theses new services?

Because it seems that Iceberg isn't available for all regions and I'm not 100% sure that it safe to use in production.

Iceberg is available in EU as /dbaas/logs today.

src/dbaas/logs/alert/alert.iceberg.service.js Outdated Show resolved Hide resolved
update: { method: "PUT" },
remove: { method: "DELETE" },
linkStream: { method: "POST", url: "/dbaas/logs/:serviceName/output/elasticsearch/alias/:aliasId/stream" },
unlinkStream: { method: "DELETE", url: "/dbaas/logs/:serviceName/output/elasticsearch/alias/:aliasId/stream/:streamId" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those should probably be in a stream submodule

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkStream: { method: "POST", url: "/dbaas/logs/:serviceName/output/elasticsearch/alias/:aliasId/stream" },
unlinkStream: { method: "DELETE", url: "/dbaas/logs/:serviceName/output/elasticsearch/alias/:aliasId/stream/:streamId" },
linkIndex: { method: "POST", url: "/dbaas/logs/:serviceName/output/elasticsearch/alias/:aliasId/index" },
unlinkIndex: { method: "DELETE", url: "/dbaas/logs/:serviceName/output/elasticsearch/alias/:aliasId/index/:indexId" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with index

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment.

Signed-off-by: Pierre De Paepe <[email protected]>
@pdepaepe
Copy link
Contributor Author

pdepaepe commented Apr 5, 2019

Thank you @marie-j for your review, i did the modifications on usual methods.

@pdepaepe pdepaepe closed this Apr 5, 2019
@pdepaepe pdepaepe reopened this Apr 5, 2019
@jleveugle jleveugle merged commit f26304f into ovh-ux:master Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

4 participants