fix(client/vehicleproperties): vehicle must be fixed for extras to apply visually #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why extras are moved up? Need the TS types updated to reflect the new optional arg. |
thelindat
requested changes
Aug 12, 2023
Comment on lines
278
to
280
| ---@param fixVehicle? boolean | ||
| ---@return boolean? | ||
| function lib.setVehicleProperties(vehicle, props) | ||
| if not DoesEntityExist(vehicle) then error(("Unable to set vehicle properties for '%s' (entity does not exist)"): | ||
| format(vehicle)) | ||
| function lib.setVehicleProperties(vehicle, props, fixVehicle) |
Comment on lines
+297
to
+302
| if props.extras then | ||
| for id, disable in pairs(props.extras) do | ||
| SetVehicleExtra(vehicle, tonumber(id) --[[@as number]], disable == 1) | ||
| end | ||
| end | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SetVehicleAutoRepairDisabled, you need to repair the vehicle for the applied extras to be visible.