Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GitHub runners to use Ubicloud #9014

Closed
wants to merge 3 commits into from
Closed

Change GitHub runners to use Ubicloud #9014

wants to merge 3 commits into from

Conversation

Electroid
Copy link
Contributor

What does this PR do?

https://twitter.com/jarredsumner/status/1759597721877647644

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Copy link
Contributor

github-actions bot commented Feb 20, 2024

@Electroid 1 files with test failures on linux-x64:

View test output

#df8be32b3e55c0208c36c66b253854e52e4c847a

Copy link
Contributor

Copy link
Contributor

@Electroid 1 files with test failures on bun-darwin-x64:

View test output

#df8be32b3e55c0208c36c66b253854e52e4c847a

Copy link
Contributor

❌🪟 @Electroid, there are 18 test regressions on Windows x86_64

  • test\bundler\bundler_edgecase.test.ts
  • test\cli\hot\hot.test.ts
  • test\cli\run\require-cache.test.ts
  • test\cli\run\transpiler-cache.test.ts
  • test\js\bun\dns\resolve-dns.test.ts
  • test\js\bun\http\fetch-file-upload.test.ts
  • test\js\bun\shell\shelloutput.test.ts
  • test\js\bun\shell\throw.test.ts
  • test\js\deno\fetch\response.test.ts
  • test\js\bun\http\bun-server.test.ts
  • test\js\node\dns\node-dns.test.js
  • test\js\node\process\process.test.js
  • test\js\third_party\es-module-lexer\es-module-lexer.test.ts
  • test\js\web\fetch\body.test.ts
  • test\js\web\fetch\body-stream.test.ts
  • test\js\web\fetch\fetch.test.ts
  • test\js\web\websocket\websocket.test.js
  • test\js\web\workers\worker.test.ts

Full Test Output

Copy link
Contributor

@jdalton jdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for digging into this @Electroid! Much needed!

@@ -48,7 +47,7 @@ jobs:
tag: linux-aarch64
arch: aarch64
build_arch: arm64
runner: linux-arm64
runner: ubicloud-standard-16-arm
Copy link
Contributor

@staabm staabm Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading the concurrency limits on https://www.ubicloud.com/docs/github-actions-integration/price-performance#concurrency-limits sounds like you should not have too much -16 jobs in parallel, as they seem to share a total of 64 CPUs (seems to depend on the pricing plan)

smaller runners also have less RAM -> its a tradeoff

Copy link

@ozgune ozgune Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, I'm Ozgun, one of Ubicloud's founders. If you drop us an email at [email protected] about concurrency limits, we'd be happy to help out.

@Electroid Electroid closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants