Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement expect().toMatchInlineSnapshot() #15570

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

pfgithub
Copy link
Contributor

@pfgithub pfgithub commented Dec 4, 2024

Fixes #3623

TODO:

  • save the updated snapshots
  • more tests
  • docs
  • consider combining the two uses of JSC::StackVisitor outside of ErrorStackTrace
  • bun test --watch hits an assertion failure in debug mode right now (and maybe windows release too)
  • bun test --watch -u uhoh.test.js (same issue in bunx jest -u --watchAll)
    function uhoh(v) {
    	expect(v).toMatchInlineSnapshot("1");
    }
    test("uhoh", () => {
    	uhoh(1);
    	uhoh(2);
    });

@robobun
Copy link

robobun commented Dec 4, 2024

@pfgithub pfgithub force-pushed the pfg/to-match-inline-snapshot branch from 5eea23a to bd8fe27 Compare December 5, 2024 02:29
@pfgithub pfgithub marked this pull request as ready for review December 5, 2024 05:19
@Jarred-Sumner Jarred-Sumner merged commit bcf023c into main Dec 5, 2024
66 of 67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the pfg/to-match-inline-snapshot branch December 5, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement inline snapshots
3 participants