-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No error is thrown when port is taken #1443
Comments
This is more complicated than it seems SO_REUSEPORT is a builtin way to do load balancing, but it only really works properly on Linux We should probably disable SO_REUSEPORT when development mode is enabled |
I think it's a potential footgun to not have this throw, even though export default {
port: 3000,
portReuse: true,
// ...
} |
This was fixed. |
@Electroid, when you mentioned that "we will modify the default behavior to indicate an error in the event of a port conflict," are you implying that the reusePort feature is being considered for deprecation? I have found the reusePort feature to be highly beneficial, as it serves as a viable alternative to PM2 cluster mode! |
This serves as a built in load balancer for me. Should it? |
@calebeaires @khaled-0 we are not deprecating Originally, |
@Jarred-Sumner, how to achieve port reuse when using |
I would expect an error to be thrown on the 2nd
serve
. There is also no error when the port is taken by a non-Bun process. Tested on MacOS Silicon, while trying to debug #247The text was updated successfully, but these errors were encountered: