recommends in metadata causes circular dependency

[jcii]

Hello,

We're seeing inconsistent behavior in our CI pipeline when we use your multipath cookbook. The metadata.rb for multipath recommends iscsi, and iscsi requires multipath.
https://github.com/ovaistariq/cookbook-multipath/blob/master/metadata.rb#L7

The inconsistency is that with this change to Berksfile:
berkshelf/berkshelf#1362

iscsi is included IF it's cached. A cookbook for our kvm server passes on our chef CI server until an outside action causes iscsi to end up in our CI server's cache. Then it starts breaking with a circular dependency error.

$ berks install
Resolving cookbook dependencies...
Fetching 'hostclass_kvm_server' from source at .
Fetching cookbook index from https://supermarket.chef.io...
There is a circular dependency between iscsi and multipath
Unable to find a solution for demands: apt (5.0.1), auditd (0.2.0), build-essential (8.0.0), chef-client (4.6.0), chef-sugar (3.4.0), chef_hostname (0.4.2), compat_resource (12.16.3)...

We could fork the cookbook, but before doing that, what do you think about removing recommends from the metadata.rb file?

Thanks

[lamont-granquist]

Chef RFC that officially drops support of recommends: https://github.com/chef/chef-rfc/blob/master/rfc085-remove-unused-metadata.md

It has also been removed from the chef-client codebase and will be removed from the berkshelf codebase soon