Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk is installed rather than tag for advanced-post-manager #292

Open
coreyworrell opened this issue Mar 13, 2019 · 5 comments
Open

Trunk is installed rather than tag for advanced-post-manager #292

coreyworrell opened this issue Mar 13, 2019 · 5 comments
Labels
bug upstream-packaging Issues that are due to WordPress.org or Subversion packaging errors

Comments

@coreyworrell
Copy link

You'll see they don't keep any code in trunk: https://plugins.trac.wordpress.org/browser/advanced-post-manager/#trunk

But there are tags with full code: https://plugins.trac.wordpress.org/browser/advanced-post-manager/#tags/4.5.0

If I specify in my composer.json "*" or "4.5.0" it installs from trunk.

@coreyworrell
Copy link
Author

coreyworrell commented Mar 13, 2019

Looking in ~/.composer/cache/repo/https---wpackagist.org/provider-wpackagist-plugin$advanced-post-manager.json I see there is an entry for 4.5 (normalized to 4.5.0.0.) pointing to trunk, and then also a 4.5.0 (also normalized to 4.5.0.0 pointing to the correct dist/zip).

Does wpackagist look at the readme.txt for versions at all? Because trunk specifies Stable tag: 4.5.0 while tag 4.5.0 specifies Stable tag: 4.5. Maybe this has something to do with it.

@roy-bongers
Copy link

roy-bongers commented May 4, 2020

The same goes for enlighter it seems. Here everything seems to be at 4.2.0 except for the plugin itself (enlighter.php file).

https://wpackagist.org/p/wpackagist-plugin/enlighter%24ebf508e505ec8f47198e73a96b602b85731dd1c4dd2ae648ddc0b7f8b57c4452.json

https://plugins.trac.wordpress.org/browser/enlighter

Edit: I just found out where it goes wrong for the enlighter plugin:
https://github.com/outlandishideas/wpackagist/blob/master/src/Command/UpdateCommand.php#L117

The $info['version'] is the version from the plugin's php file. Where the other versions are the svn tags. The version in the php file doesn't match any of the tags and therefore it set's the current "wordpress" version to trunk.

@NoelLH
Copy link
Contributor

NoelLH commented Dec 22, 2020

Let's re-test this once recent refactor changes are out. See #350, #368

@NoelLH
Copy link
Contributor

NoelLH commented Dec 23, 2020

I think this is a live issue, but as you suggest is down to the published package data not being self-consistent in this particular case. I'm not sure the complexity of parsing versions differently to work around this is necessarily worth it but I'm definitely open to PRs if they can address this without significantly slowing down the update process.

@NoelLH NoelLH removed their assignment Dec 23, 2020
@NoelLH NoelLH added the upstream-packaging Issues that are due to WordPress.org or Subversion packaging errors label Dec 27, 2020
@ethanclevenger91
Copy link

Bugged the Tribe team here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream-packaging Issues that are due to WordPress.org or Subversion packaging errors
Projects
None yet
Development

No branches or pull requests

4 participants