Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sure where to ask questions. #13

Open
gdey opened this issue Apr 18, 2020 · 0 comments
Open

Not sure where to ask questions. #13

gdey opened this issue Apr 18, 2020 · 0 comments

Comments

@gdey
Copy link

gdey commented Apr 18, 2020

I'm sorry if this isn't the correct place, just point me to the correct place.

First off thank you for this bit of code.

I have a few questions as I'm exploring the ThreeLegged API's for the forge.

  1. I noticed that the tests under OAuth are still pointing to apprentice3d's repo. I believe this is an error. Would you be amenable to a pull request that fixes this?

  2. What is the reasoning behind *HubAPI3L's methods not being the same as HubAPI? I am unable to come up with a reason for GetHubs to be renamed to GetHubsThreeLegged. Having two different names to get hubs (this applies to other objects as well), make it difficult to swap between the two objects. I have an application where it would be useful to support both 2 and 3 legged auth depending on how the application is installed and called.

It seems to me for the ThreeLegged API that mirrors the TwoLegged one could have the same method name on the ThreeLegged v.s. the TwoLegged models. Then an Interface can be defined for getting hubs, projects, items, etc...

Thank you, for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant