Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDE GUIDE ISSUE] Saving and resetting form #125

Open
gtsueng opened this issue Jun 4, 2020 · 2 comments
Open

[DDE GUIDE ISSUE] Saving and resetting form #125

gtsueng opened this issue Jun 4, 2020 · 2 comments
Labels
bug Something isn't working high priority usability

Comments

@gtsueng
Copy link
Collaborator

gtsueng commented Jun 4, 2020

The form autosaves, which seems to be a potential source of error that may affect the integrity of the data. Allowing a manual trigger to save may help.

Reset issue that may cause data integrity problems:

  1. After entering a sample metadata and getting as far as the 'submit' screen, clicked on the 'start over' button. Got the warning sign that this action can't be reverted
  2. Start over, doesn't actually clear the form, so user must manually remove/replace items
  3. If user removes something, it doesn't necessarily disappear from the saved json
  4. User can get to submission page (and even submit, IF not for the funder name issue) with mismatching data.

Funder manually removed as seen here:
should not have funding

But, when I checked the json after clicking 'submit' (fortunately, submission doesn't work), the funder previous was still saved in the json.
guide preview

@gtsueng gtsueng added bug Something isn't working usability labels Jun 4, 2020
@flaneuse
Copy link
Collaborator

flaneuse commented Jun 4, 2020

A few additional notes:

  • Removing all cookies doesn't actually remove the locally stored data in Chrome. This makes it difficult if not impossible to start over, for the reasons @gtsueng mentioned above.
  • Changing to a new browser thankfully allows you to get to a new form.
  • Would suggest changing "Import Metadata" via .json function from APPENDING the .json fields to the from to REPLACING it. I thought I'd try to be clever and import a blank .json file or one with just the name filled out, but that kept all the existing autosaved data.
  • I actually didn't notice that the form was autosaving and was concerned that after spending ~ 1 h filling out the form, all my work would be lost. Make the "autosaving" notification more prominent?
  • Might be nice to also add an explicit save button, to make the user feel in control of the process.

@flaneuse
Copy link
Collaborator

flaneuse commented Jun 4, 2020

Clicking "back" after successfully registering a dataset also doesn't clear the form... and refreshing the page means the most recently registered dataset remains #zombiedata @marcodarko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority usability
Projects
None yet
Development

No branches or pull requests

2 participants