Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_major_lineage_prevalence date handling #102

Open
mindoftea opened this issue Jul 28, 2023 · 0 comments
Open

Update get_major_lineage_prevalence date handling #102

mindoftea opened this issue Jul 28, 2023 · 0 comments

Comments

@mindoftea
Copy link
Collaborator

Per discussion on PR #87, the get_major_lineage_prevalence function needs to be changed to take into account the min_date and max_date for filtering. The function has been updated (see commit 9cee401) to take these arguments as appropriate, however the output is not yet correct and the logic needs to be changed (see lines 208-215 of util.py in particular). The intended behavior would be to select records between min_date and max_date if they are specified, or records up to ndays before the present (defaulting to 180) otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant