Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 announce #284

Merged
merged 8 commits into from
Apr 16, 2024
Merged

2024 announce #284

merged 8 commits into from
Apr 16, 2024

Conversation

garrying
Copy link
Member

@garrying garrying commented Apr 9, 2024

No description provided.

@garrying garrying force-pushed the 2024-announce branch 4 times, most recently from dbd9831 to c3e0708 Compare April 11, 2024 03:07
</header>
{{ content }}
Copy link
Member

@dcwalk dcwalk Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we talked about updating this ascii image and changing what is in the laptop screen

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with rotating slogans

@@ -10,3 +10,17 @@
</div>
</div>
</footer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the more I think about this footer image I think that some other jgs might feel personally more suited to the location and my interpretation of look and feel. I'll add to comment at end of review

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with the second jgs piece your comment.

Copy link
Member

@dcwalk dcwalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our review yesterday we identified this as needed before merging:

  • add credit for ascii art and font to about page
  • integrate the divider style more to other content / pages

After looking at other jgs ascii art I feel relatively strong that we can find one of their works that feels more suited to time and place (Vancouver where sea meets the sky) for the footer.

If what was interesting was how they represented organic things with ascii symbols, organic things that reflect the actual landscape of vancouver are: trees, oceans, mountains.

Could we try the footer with ascii art that references those?

Some jgs options:

                         |    
                     \       /            _\/_
                       .-'-.              //o\  _\/_
    _  ___  __  _ --_ /     \ _--_ __  __ _ | __/o\\ _
  =-=-_=-=-_=-=_=-_= -=======- = =-=_=-=_,-'|"'""-|-,_ 
   =- _=-=-_=- _=-= _--=====- _=-=_-_,-"          |
  jgs=- =- =-= =- = -  -===- -= - ."
  
        _    .  ,   .           .
    *  / \_ *  / \_      _  *        *   /\'__        *
      /    \  /    \,   ((        .    _/  /  \  *'.
 .   /\/\  /\/ :' __ \_  `          _^/  ^/    `--.
    /    \/  \  _/  \-'\      *    /.' ^_   \_   .'\  *
  /\  .-   `. \/     \ /==~=-=~=-=-;.  _/ \ -. `_/   \
 /  `-.__ ^   / .-'.--\ =-=~_=-=~=^/  _ `--./ .-'  `-
/jgs     `.  / /       `.~-^=-=~=^=.-'      '-._ `._

    .                  .-.    .  _   *     _   .
           *          /   \     ((       _/ \       *    .
         _    .   .--'\/\_ \     `      /    \  *    ___
     *  / \_    _/ ^      \/\'__        /\/\  /\  __/   \ *
       /    \  /    .'   _/  /  \  *' /    \/  \/ .`'\_/\   .
  .   /\/\  /\/ :' __  ^/  ^/    `--./.'  ^  `-.\ _    _:\ _
     /    \/  \  _/  \-' __/.' ^ _   \_   .'\   _/ \ .  __/ \
   /\  .-   `. \/     \ / -.   _/ \ -. `_/   \ /    `._/  ^  \
  /  `-.__ ^   / .-'.--'    . /    `--./ .-'  `-.  `-. `.  -  `.
@/        `.  / /      `-.   /  .-'   / .   .'   \    \  \  .-  \%
@&8jgs@@%% @)&@&(88&@.-_=_-=_-=_-=_-=_.8@% &@&&8(8%@%8)(8@%8 8%@)%
@88:::&(&8&&8:::::%&`.~-_~~-~~_~-~_~-~~=.'@(&%::::%@8&8)::&#@8::::
`::::::8%@@%:::::@%&8:`.=~~-.~~-.~~=..~'8::::::::&@8:::::&8:::::'
 `::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::.'

and another one:

                                /^L_      ,."\
           /~\       __       /~    \   ./    \
          /   _\   _/  \     /T~\|~\_\ / \_  /~|          _^
        / \ /W  \ / V^\/X  /~         T  . \/   \    ,v-./
 ,'`-. /~   ^     H  ,  . \/    ;   .   \      `. \-'   /
     M      ~     | . ;  /         ,  _   :  .    ~\_,-'
    /    ~    .    \    /   :                   '   \   ,/`
   I o. ^    oP     '98b         -      _  9.`       `\9b.
 8oO888.  oO888P  d888b9bo. .8o 888o.       8bo.  o     988o.
 88888888888888888888888888bo.98888888bo.    98888bo. .d888P
 88888888888888888888888888888888888888888888888888888888888
 88888888888888P"   "" "   """9888P" P" "8P"   ""*9888888888

by Veer Kothari + Ojosh!ro

@garrying garrying force-pushed the 2024-announce branch 4 times, most recently from 7cf09ee to c79fe96 Compare April 13, 2024 12:49
@dcwalk
Copy link
Member

dcwalk commented Apr 15, 2024

@garrying apologies on my slow reply -- looks amazing!

However, the two ascii works now have scroll bats for me, I tested on both chromium and firefox with same behaviour. Also the footer feels like it's missing maybe a bit of spacing before the end of the page (unless that is intentional) . screenshot attached

image

@garrying garrying merged commit 91001fd into main Apr 16, 2024
1 check passed
garrying added a commit that referenced this pull request Apr 16, 2024
* update

* update

* screen

* attr

* dividers

* footer

* role

* fix overflow
garrying added a commit that referenced this pull request Apr 16, 2024
* update

* update

* screen

* attr

* dividers

* footer

* role

* fix overflow
garrying added a commit that referenced this pull request Apr 16, 2024
* update

* update

* screen

* attr

* dividers

* footer

* role

* fix overflow
garrying added a commit that referenced this pull request Apr 18, 2024
* update

* update

* screen

* attr

* dividers

* footer

* role

* fix overflow
garrying added a commit that referenced this pull request Apr 19, 2024
* update

* update

* screen

* attr

* dividers

* footer

* role

* fix overflow
@dcwalk dcwalk deleted the 2024-announce branch May 31, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants