From 346835dadf9d134cdaf62c0672c12294d354e40d Mon Sep 17 00:00:00 2001 From: Bilka Date: Sun, 13 Aug 2023 12:03:35 +0200 Subject: [PATCH 1/3] AO3-6590 Add reviewdog ERB lint runner --- .github/workflows/reviewdog.yml | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 .github/workflows/reviewdog.yml diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml new file mode 100644 index 00000000000..3705cb55105 --- /dev/null +++ b/.github/workflows/reviewdog.yml @@ -0,0 +1,27 @@ +# Based on https://github.com/tk0miya/action-erblint/blob/main/README.md#example-usage + +name: Reviewdog ERB Lint + +on: [pull_request] + +permissions: + checks: write + +jobs: + erb-lint: + name: ERB Lint runner + runs-on: ubuntu-latest + steps: + - name: Check out code + uses: actions/checkout@v3 + + - name: Set up Ruby and run bundle install + uses: ruby/setup-ruby@v1 + with: + bundler-cache: true + + - name: erb-lint + uses: tk0miya/action-erblint@667687e73b44e7b7a710a1204b180f49f80ebb5e + with: + use_bundler: true + reporter: github-pr-check # default From 47f522316661c9a3c3855ca8402b9f883ea8f9e7 Mon Sep 17 00:00:00 2001 From: Bilka Date: Tue, 15 Aug 2023 17:24:44 +0200 Subject: [PATCH 2/3] AO3-6590 Remove erb lint from Hound It doesn't work. And if that would be fixed in the future, it would be linting twice. --- .hound.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.hound.yml b/.hound.yml index f544a38eee4..42909ccedb6 100644 --- a/.hound.yml +++ b/.hound.yml @@ -1,10 +1,6 @@ # Available linter versions: # http://help.houndci.com/en/articles/2461415-supported-linters -erblint: - enabled: true - config_file: .erb-lint.yml - jshint: config_file: .jshintrc ignore_file: .jshintignore From 41b8dfffe5e5c3701de09def6f6b9c45e106d984 Mon Sep 17 00:00:00 2001 From: Bilka Date: Tue, 15 Aug 2023 17:28:17 +0200 Subject: [PATCH 3/3] AO3-6590 Rename reviewdog workflow to be more generic --- .github/workflows/reviewdog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 3705cb55105..c86a098d193 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -1,6 +1,6 @@ # Based on https://github.com/tk0miya/action-erblint/blob/main/README.md#example-usage -name: Reviewdog ERB Lint +name: Reviewdog on: [pull_request]