Add regexp/simplify-set-operations rule
#595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: efca081 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Now that regexpp has been fixed, I think it's ready for review. |
|
Also, the code for getting escapes right when inlining character classes looks very complex. Maybe we could say that this rule only removes negations and doesn't inline character classes? E.g. |
I think that's a good idea! I will change the rule. |
ota-meshi
changed the title
regexp/require-reduce-negation ruleregexp/simplify-set-operations rule
Co-authored-by: Michael Schmidt <[email protected]>
RunDevelopment
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #574
I found a bug in
regexppwhile implementing this rule. We need to fix that first.eslint-community/regexpp#136
If you have an idea for a better rule name, please let me know. I can rename the rule name.