You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently all settings are read from config.yaml as is. As documented in the config file design, we want to allow sensitive values to be read from environment variables, instead of needing to be written down and commited in config.yaml.
Unsure if we want this to only be for credential settings, or allow overrides for any setting from an envvar (this might be impossible without restructuring how we parse stuff to allow defaults for all values).
I see two ways to do this:
"silent" overrides where the target setting is parsed from the envvar name:
I support explicit envvar setting
It makes it clearer what is happening without having to reference the docs for what the silent overrides are. And making Serde happier is a bonus
Currently all settings are read from
config.yaml
as is. As documented in the config file design, we want to allow sensitive values to be read from environment variables, instead of needing to be written down and commited inconfig.yaml
.Unsure if we want this to only be for credential settings, or allow overrides for any setting from an envvar (this might be impossible without restructuring how we parse stuff to allow defaults for all values).
I see two ways to do this:
The latter might be easier to do with the way Serde wants to parse stuff.
The text was updated successfully, but these errors were encountered: