Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid syntax in .d.ts files in Typescript 3.9 #33

Closed
ostrowr opened this issue May 21, 2020 · 1 comment
Closed

Invalid syntax in .d.ts files in Typescript 3.9 #33

ostrowr opened this issue May 21, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@ostrowr
Copy link
Owner

ostrowr commented May 21, 2020 •
edited
Loading

Typescript 3.9 introduced a cap on type size. It's easy to reach that cap when using this library.

See microsoft/TypeScript#38557 for more information and details about the workarounds.

Describe the bug
.d.ts files are truncated, producing invalid syntax. "..."

To work around this, you can try the fix described here: microsoft/TypeScript#38557 (comment) or (possibly) split up your schemas into several files.

You can also continue to use 3.7 or 3.8 until this is fixed.

I'm hoping the Typescript maintainers change their mind about this cap.

To Reproduce
Any sufficiently complicated (set of) schemas in some file may hit this cap.

Expected behavior
tsc produces valid code

Actual behavior
tsc produces invalid code
@ostrowr ostrowr added the triage label May 21, 2020
@ostrowr ostrowr self-assigned this May 21, 2020
@ostrowr ostrowr added help wanted Extra attention is needed and removed triage labels May 21, 2020
@ostrowr ostrowr removed their assignment May 21, 2020
@ostrowr ostrowr changed the title [BUG] Invalid syntax in .d.ts files Invalid syntax in .d.ts files in Typescript 3.9 May 21, 2020
@ostrowr ostrowr pinned this issue May 21, 2020
@ostrowr
Copy link
Owner Author

ostrowr commented Mar 16, 2021 •
edited
Loading

Fixed in Typescript 4.1; see microsoft/TypeScript#38557

@ostrowr ostrowr closed this as completed Mar 16, 2021
@ostrowr ostrowr unpinned this issue Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ostrowr