Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RtmpUint16 UnmarshalBinary incorrect byteorder #55

Open
avfedorov opened this issue Apr 5, 2016 · 1 comment
Open

RtmpUint16 UnmarshalBinary incorrect byteorder #55

avfedorov opened this issue Apr 5, 2016 · 1 comment
Labels
bug

Comments

@avfedorov
Copy link

Byteorder in protocol.RtmpUint16 UnmarshalBinary is incorrect.
Current:
*v = RtmpUint16(uint16(data[0]) | uint16(data[1])<<8)
Must be:
*v = RtmpUint16(uint16(data[1]) | uint16(data[0])<<8)

This leads to an incorrect decoding of UserControlMessage for example.
@winlinvip winlinvip added the bug label Apr 6, 2016
@winlinvip
Copy link
Member

Thanks， I will check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@winlinvip @avfedorov