Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add line number to Token-Permissions detail reporting #886

Closed
laurentsimon opened this issue Aug 23, 2021 · 4 comments · Fixed by #1381
Closed

Feature: add line number to Token-Permissions detail reporting #886

laurentsimon opened this issue Aug 23, 2021 · 4 comments · Fixed by #1381
Assignees
@ristomcgehee
Labels
kind/enhancement New feature or request
Milestone
v4

Comments

@laurentsimon
Copy link
Contributor

see the title. It's identical to #725 but for Token-Permissions check.
@laurentsimon laurentsimon added the kind/enhancement New feature or request label Aug 23, 2021
@laurentsimon
Copy link
Contributor Author

FYI @chrismcgehee

@laurentsimon laurentsimon added this to the milestone-q3 milestone Aug 23, 2021
@laurentsimon
Copy link
Contributor Author

@chrismcgehee I think you're working on it, right? Assigning to you. If you're not, please un-assign.

@ristomcgehee ristomcgehee mentioned this issue Dec 5, 2021
Merged
2 tasks
@laurentsimon
Copy link
Contributor Author

Does #1363 close this issue?

@ristomcgehee
Copy link
Contributor

Does #1363 close this issue?

It does not. These functions (and the functions they call) still need the line number to be set correctly:

The fix here will be more involved because we'll have to go several steps up in the call stack to pass in a structured object instead of a string.

@ristomcgehee ristomcgehee mentioned this issue Dec 12, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ristomcgehee ristomcgehee

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
v4
2 participants
@ristomcgehee @laurentsimon