Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document and implement changes to the BigQuery schema #4299

Open
3 tasks
spencerschrock opened this issue Aug 13, 2024 · 1 comment
Open
3 tasks

document and implement changes to the BigQuery schema #4299

spencerschrock opened this issue Aug 13, 2024 · 1 comment
Labels
area/bigquery cron-job kind/docs Improvements or additions to documentation

Comments

@spencerschrock
Copy link
Member

Right now, there are two breaking changes to the JSON output that would affect the upload step of our weekly scan infrastructure.

  1. Maintainer annotations, which got merged in ⚠️ Add initial Maintainers Annotation parsing #3905 without modifying cron/internal/format/json.go
  2. Adding a check ID in ✨ Add check ID #4021 , which currently does touch its cron/internal/format/json.go

This results in a few required steps:

  • document the steps these kind of changes required and flag them in our CI
  • make the required schema change to support both of these in the BQ table
  • wait on ✨ Add check ID #4021 or merge without the changes to cron/internal/format/json.go
@spencerschrock spencerschrock added kind/docs Improvements or additions to documentation cron-job area/bigquery labels Aug 13, 2024
@spencerschrock spencerschrock changed the title document and implement breaking changes to the BigQuery table document and implemen changes to the BigQuery schema Aug 13, 2024
@spencerschrock spencerschrock changed the title document and implemen changes to the BigQuery schema document and implement changes to the BigQuery schema Aug 13, 2024
@spencerschrock
Copy link
Member Author

cc @ashearin regarding #4021, if you want to merge partially or wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bigquery cron-job kind/docs Improvements or additions to documentation
Projects
Status: No status
Development

No branches or pull requests

1 participant