🌱 Cleanup codeApproved outcomes and semantics #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
count the number of approved vs unapproved changesets Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3902 +/- ##
==========================================
- Coverage 75.08% 66.68% -8.41%
==========================================
Files 234 234
Lines 15857 15860 +3
==========================================
- Hits 11907 10577 -1330
- Misses 3189 4629 +1440
+ Partials 761 654 -107 |
laurentsimon
approved these changes
Feb 27, 2024
raghavkaul
reviewed
Feb 28, 2024
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
* tidy probe documentation Signed-off-by: Spencer Schrock <[email protected]> * export probe name Signed-off-by: Spencer Schrock <[email protected]> * check for no raw data Signed-off-by: Spencer Schrock <[email protected]> * return OutcomeNotApplicable when no changesets are present Signed-off-by: Spencer Schrock <[email protected]> * extract approved logic and return errors as OutcomeError Signed-off-by: Spencer Schrock <[email protected]> * simplify finding creation Signed-off-by: Spencer Schrock <[email protected]> * add clarifying comment for skipping bot changes Signed-off-by: Spencer Schrock <[email protected]> * only bot commits results in OutcomeNotApplicable Signed-off-by: Spencer Schrock <[email protected]> * move no changeset code back to where it was originally Signed-off-by: Spencer Schrock <[email protected]> * include ratio of approved/total as values count the number of approved vs unapproved changesets Signed-off-by: Spencer Schrock <[email protected]> * ensure unreviewed bot PRs always give negative outcome Signed-off-by: Spencer Schrock <[email protected]> * use common outcome test code Signed-off-by: Spencer Schrock <[email protected]> * fix linter Signed-off-by: Spencer Schrock <[email protected]> * mention dependabot in probe description Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
probe tidy
What is the current behavior?
The probes dont follow the standard behavior of the other probes.
What is the new behavior (if this is a feature change)?**
Values, this will be used by the evaluation codeWhich issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)