🌱 Combine fuzzing probes #3877
Merged
🌱 Combine fuzzing probes #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
|
Still have a couple TODOs, especially around remediation and supported tools so still a draft. I know there has been discussion about continuous fuzzing in the past being different than the fuzzing libraries. While this PR combines everything into one probe, I don't think this limits the introduction of a continuous fuzzing probe in the future. For example: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3877 +/- ##
==========================================
- Coverage 75.07% 68.46% -6.61%
==========================================
Files 234 222 -12
Lines 15881 15807 -74
==========================================
- Hits 11922 10823 -1099
- Misses 3196 4289 +1093
+ Partials 763 695 -68 |
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
force-pushed
the
fuzzing-combine-probes
branch
from
54684c9 to
494a57e
Compare
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
force-pushed
the
fuzzing-combine-probes
branch
from
494a57e to
2eaf3b0
Compare
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
laurentsimon
approved these changes
Mar 6, 2024
|
/scdiff generate Fuzzing |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
* single fuzz probe boilerplate Signed-off-by: Spencer Schrock <[email protected]> * initial implementation Signed-off-by: Spencer Schrock <[email protected]> * connect fuzzing probe to eval code Signed-off-by: Spencer Schrock <[email protected]> * include fuzzer name as tool Signed-off-by: Spencer Schrock <[email protected]> * connect to probes flag Signed-off-by: Spencer Schrock <[email protected]> * remove old probes from list Signed-off-by: Spencer Schrock <[email protected]> * remove old probes Signed-off-by: Spencer Schrock <[email protected]> * fix failing test Signed-off-by: Spencer Schrock <[email protected]> * add tool value to test Signed-off-by: Spencer Schrock <[email protected]> * add fuzz tool helper Signed-off-by: Spencer Schrock <[email protected]> * specify supported tools Signed-off-by: Spencer Schrock <[email protected]> * update e2e test Signed-off-by: Spencer Schrock <[email protected]> * check for no raw data Signed-off-by: Spencer Schrock <[email protected]> * add basic tests Signed-off-by: Spencer Schrock <[email protected]> * add test to ensure fuzzer location is propagated Signed-off-by: Spencer Schrock <[email protected]> * expand detailed tests to include other info like tool value Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
What is the current behavior?
Each fuzzing tool has its own probe
What is the new behavior (if this is a feature change)?**
There's only one fuzzing probe, and a "tool" value specifies which tool is used.
Which issue(s) this PR fixes
Related to #3824
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)