-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enable users to integrate external checks via blank-imports #3809
Conversation
Signed-off-by: John Andersen <[email protected]>
checks/dynamic.go
Outdated
"strings" | ||
) | ||
|
||
const CheckDynamicPluginLocationEnvironmentVariable = "SCORECARD_DYNAMIC_CHECKS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename to
checks/plugins.go
Signed-off-by: John Andersen <[email protected]>
Signed-off-by: John Andersen <[email protected]>
a5b0675
to
376ba3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are trying to avoid using plugins for the reasons specified in #3095
cc @naveensrinivasan for possible coordination |
Thanks @spencerschrock, so just to clarify focus of this PR would be on the check docs side of things? |
There's still the aspect of the changes outlined in #3095, and the followup comment #3095 (comment). |
This pull request is stale because it has been open for 10 days with no activity |
I apologize for the delayed response. I will be working on this. Thanks! |
Should I close this PR then?
…On Wed, Feb 7, 2024 at 11:40 Naveen ***@***.***> wrote:
I apologize for the delayed response. I will be working on this. Thanks!
—
Reply to this email directly, view it on GitHub
<#3809 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNMXYMCNICMJJ6J56Q5ENDYSPKCXAVCNFSM6AAAAABCA4DPX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSG42DIMBRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I'm not sure about Naveen's expected timeline, but I'll go ahead and close this for now. |
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?**
SCORECARD_DYNAMIC_CHECKS
environment variable which leverages Golang plugins
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
TODO
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)