Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve Branch-Protection score calculation #2796

Closed
gabibguti opened this issue Mar 27, 2023 · 2 comments
Closed

Feature: Improve Branch-Protection score calculation #2796

gabibguti opened this issue Mar 27, 2023 · 2 comments
Labels
kind/enhancement New feature or request

Comments

@gabibguti
Copy link
Contributor

gabibguti commented Mar 27, 2023

Is your feature request related to a problem? Please describe.
Following this discussion #2772 (comment)

As I understand the Branch-Protection score is divided by tier and each tier has a group of settings. Over time, the settings moved from one tier to another, moved from non-admin to admin classification and new settings were added. That's why enabling some settings do not have the intended effect on the score.

Describe the solution you'd like
For me, the score should be count 1 point for each setting but when using non-admin token if you reached all the tier settings you could do you get the max points for that tier.

E.g. Using non-admin token, to reach tier 3 you need to enable 7 settings. Currently, tier 3 counts as 8/10, but by this proposal should be 7/10.

Describe alternatives you've considered
As an alternative, the tier scores could be maintained but make sure all settings count.

E.g. Using non-admin token, when you reach tier 3 you have 8/10. To reach tier 4 (9/10) you need to enable 2 settings, but only one of them makes you get 9/10, the other does not count. To make it proportional, you should enable both settings to reach 9/10.

Additional context
None.

@gabibguti gabibguti added the kind/enhancement New feature or request label Mar 27, 2023
@gabibguti gabibguti changed the title Improve Branch-Protection score calculation Feature: Improve Branch-Protection score calculation Mar 27, 2023
@github-actions
Copy link

Stale issue message - this issue will be closed in 7 days

@spencerschrock
Copy link
Member

Going to close in favor of discussion in #3123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants